chore(python): in .coveragerc, ignore branches that aren't really branches #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nches We don't expect `with pytest.raises...:` "branches" to fail in passing tests.
|
@tswast , Please could you file an issue https://github.com/googleapis/synthtool/issues/new?assignees=&labels=&projects=&template=bug_report.md with a link to an example of the problem to help with the review? |
|
Strangely I'm not able to reproduce anymore. Maybe it was a bad "coverage" package release or something? |
|
For future reference, I was able to reproduce when I only ran the Python 3.9 unit tests, followed by cover. With Python 3.10 unit tests, the coverage report correctly omits these "branches". |
|
I'm not sure if it's related but I ran into a similar issue where there was a python 3.9 coverage gap when testing async code. googleapis/gapic-generator-python#1174 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't expect
with pytest.raises...:"branches" to fail in passing tests.