Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python_mono_repo): add python runtimes for system tests #1869

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Sep 22, 2023

In noxfile.py in the python monorepo, there are no python runtimes populated for system testing. See https://github.com/googleapis/google-cloud-python/blob/8cf3ccd69f3575d99690ded3efb60f79607ea18e/packages/google-cloud-access-approval/noxfile.py#L49

The line
SYSTEM_TEST_PYTHON_VERSIONS = []
should be
SYSTEM_TEST_PYTHON_VERSIONS = ["3.7", "3.8", "3.9", "3.10", "3.11"]

I've excluded python 3.7 for system tests in this PR. We have no plans to use the runtime in system tests as it is unsupported in the python community.

@parthea parthea merged commit ee41a29 into master Sep 22, 2023
10 checks passed
@parthea parthea deleted the add-python-runtimes-for-system-tests branch September 22, 2023 20:44
parthea added a commit to googleapis/google-cloud-python that referenced this pull request Sep 25, 2023
This PR updates the post processor image to the latest one which is
`gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo@sha256:2504e243aeb46a96e5012409500fd35b01b86855bc4b916646d8b179b2908741`.

The latest image includes the following fixes:
googleapis/synthtool#1869

Run the following commands to obtain the latest sha256
```
docker pull gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest
```

```
partheniou@partheniou-vm-3:~$ docker inspect --format='{{.RepoDigests}}' gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo:latest
[gcr.io/cloud-devrel-public-resources/owlbot-python-mono-repo@sha256:2504e243aeb46a96e5012409500fd35b01b86855bc4b916646d8b179b2908741]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants