-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade Gradle build system in generated library repo and fix setup issue #876
Conversation
Codecov Report
@@ Coverage Diff @@
## main #876 +/- ##
=======================================
Coverage 87.84% 87.84%
=======================================
Files 153 153
Lines 15966 15966
Branches 1155 1155
=======================================
Hits 14025 14025
Misses 1601 1601
Partials 340 340 Continue to review full report at Codecov.
|
@chanseokoh @meltsufin This change, since now the generated templates depend on gradle 7 broke the self-service workflow, because |
#884 will fix #876 (comment) |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api:gax-bom](https://togithub.com/googleapis/gax-java) | `2.18.4` -> `2.18.5` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api:gax-bom/2.18.5/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api:gax-bom/2.18.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api:gax-bom/2.18.5/compatibility-slim/2.18.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api:gax-bom/2.18.5/confidence-slim/2.18.4)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/gax-java</summary> ### [`v2.18.5`](https://togithub.com/googleapis/gax-java/blob/HEAD/CHANGELOG.md#​2185-httpsgithubcomgoogleapisgax-javacomparev2184v2185-2022-07-25) [Compare Source](https://togithub.com/googleapis/gax-java/compare/v2.18.4...v2.18.5) ##### Bug Fixes - **deps:** update dependency com.google.api.grpc:grpc-google-common-protos to v2.9.2 ([#​1735](https://togithub.com/googleapis/gax-java/issues/1735)) ([d7f00be](https://togithub.com/googleapis/gax-java/commit/d7f00beae84c093a732982aaeedd7d6a8752e52c)) - **deps:** update dependency com.google.api.grpc:proto-google-common-protos to v2.9.2 ([#​1736](https://togithub.com/googleapis/gax-java/issues/1736)) ([ee3d4ad](https://togithub.com/googleapis/gax-java/commit/ee3d4ad29a84da9113790dd03b8f0bbd89625a7c)) - **deps:** update dependency com.google.auth:google-auth-library-credentials to v1.8.1 ([#​1737](https://togithub.com/googleapis/gax-java/issues/1737)) ([24bc629](https://togithub.com/googleapis/gax-java/commit/24bc629aa1ffc0513ba766858935ead7ab18bf9e)) - **deps:** update dependency com.google.auth:google-auth-library-oauth2-http to v1.8.1 ([#​1738](https://togithub.com/googleapis/gax-java/issues/1738)) ([1030eb6](https://togithub.com/googleapis/gax-java/commit/1030eb6b1df5008f304d0989fd991f88f148cc2a)) - **deps:** update dependency com.google.cloud:google-cloud-shared-config to v1.5.1 ([#​1726](https://togithub.com/googleapis/gax-java/issues/1726)) ([bdffb86](https://togithub.com/googleapis/gax-java/commit/bdffb86c05235c4ad783ab7afd28724386465569)) - **deps:** update dependency com.google.http-client:google-http-client-bom to v1.42.2 ([#​1727](https://togithub.com/googleapis/gax-java/issues/1727)) ([030e9b3](https://togithub.com/googleapis/gax-java/commit/030e9b33ec6bd98122fba59a1bc39513444c3511)) - **deps:** update dependency com.google.protobuf:protobuf-bom to v3.21.3 ([#​1742](https://togithub.com/googleapis/gax-java/issues/1742)) ([9215e1f](https://togithub.com/googleapis/gax-java/commit/9215e1f58ebcc6eccef42c53981ab90865fe366a)) - **deps:** update dependency io.grpc:grpc-bom to v1.48.0 ([#​1741](https://togithub.com/googleapis/gax-java/issues/1741)) ([4735a4b](https://togithub.com/googleapis/gax-java/commit/4735a4b29b686ba510a25ad8458142870e50b1c5)) - remove initialization of logger classes which is conflicting with slf4j ([#​1733](https://togithub.com/googleapis/gax-java/issues/1733)) ([ccaf265](https://togithub.com/googleapis/gax-java/commit/ccaf26537a189dacb9b3bb58760a4c6f6cd48a87)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjMyLjEyNy4wIn0=-->
🤖 I have created a release *beep* *boop* --- ## [2.8.3](googleapis/java-core@v2.8.2...v2.8.3) (2022-07-26) ### Dependencies * update dependency com.google.api-client:google-api-client-bom to v2 ([#868](googleapis/java-core#868)) ([fe7991d](googleapis/java-core@fe7991d)) * update dependency com.google.api:gax-bom to v2.18.4 ([#864](googleapis/java-core#864)) ([d4a8501](googleapis/java-core@d4a8501)) * update dependency com.google.api:gax-bom to v2.18.5 ([#876](googleapis/java-core#876)) ([e2c0c13](googleapis/java-core@e2c0c13)) * update dependency com.google.api.grpc:proto-google-common-protos to v2.9.2 ([#870](googleapis/java-core#870)) ([adf5af4](googleapis/java-core@adf5af4)) * update dependency com.google.api.grpc:proto-google-iam-v1 to v1.5.2 ([#865](googleapis/java-core#865)) ([5dad1ea](googleapis/java-core@5dad1ea)) * update dependency com.google.auth:google-auth-library-bom to v1.8.1 ([#856](googleapis/java-core#856)) ([bb58609](googleapis/java-core@bb58609)) * update dependency com.google.http-client:google-http-client-bom to v1.42.2 ([#871](googleapis/java-core#871)) ([341b04e](googleapis/java-core@341b04e)) * update dependency com.google.protobuf:protobuf-bom to v3.21.3 ([#874](googleapis/java-core#874)) ([efe8c28](googleapis/java-core@efe8c28)) * update dependency com.google.protobuf:protobuf-bom to v3.21.4 ([#877](googleapis/java-core#877)) ([25bea6c](googleapis/java-core@25bea6c)) * update dependency io.grpc:grpc-bom to v1.48.0 ([#873](googleapis/java-core#873)) ([8bfee63](googleapis/java-core@8bfee63)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Gradle 4.10.3 is ancient. We cannot delay upgrading Gradle forever.
Also, the following logic was incomplete in that it included directories (basically every non-hidden directory) that were not supposed to be included.
For example, a generated library always contains a directory called
gradle/
, and it was being included. (It's a minor point, but the regex".*/\\..*"
doesn't make sense to me either.)Tested the changes by running
bazel build google/cloud/compute/v1:google-cloud-compute-v1-java
, unzippinggoogle-cloud-compute-v1-java.tar.gz
, and running./gradlew check publishToMavenLocal
.