Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add hardcoded LRO implementation for rest transport #823

Conversation

GabrielGonzalezDiaz
Copy link
Contributor

Adding hardcoded machinery to composer/rest

Changes

HttpJsonServiceStubClassComposer

Added 2 new methods to generate .setSnapshotFactory() and .setPollingRequestFactory() using the AST model already established.

Problem:
This version is currently hard coded as it does not use the new annotations for LRO.

HttpJsonServiceCallableFactoryClassComposer

Modified 1 method to generate createOperationCallable() using the AST model already established. The previous version generated the header of the method with an empty body and returned null. I took the already generated MethodDefinition to add the variables needed in the body for the return statement.

Problem:
Generic types in the generics for a new object are not currently supported, so to get around that I created a VaporReference with the same pakkage as the class being generated such that the import will be ignored. This is a temporary solution.

@GabrielGonzalezDiaz GabrielGonzalezDiaz requested review from miraleung and a team as code owners August 12, 2021 20:05
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2021
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the baseline and integration test files changes (you added changes in the generator, so now it generates new stuff, and that new stuff now must be reflected in the expected baseline and integration test files).

TypeNode statusType = TypeNode.withReference(
VaporReference.builder()
.setName("Status")
.setPakkage("com.google.cloud.compute.v1")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For every line of code, which has now compute hardcoded, add a corresponding TODO (that will be easy to search for , when we will be replacing the hardcoded parts).

@vam-google vam-google changed the title chore: add hardcoded LRO machinery chore: add hardcoded LRO implementation for rest transport Aug 13, 2021
suztomo pushed a commit that referenced this pull request Mar 21, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [click](https://palletsprojects.com/p/click/) ([changelog](https://click.palletsprojects.com/changes/)) | `==8.0.4` -> `==8.1.3` | [![age](https://badges.renovateapi.com/packages/pypi/click/8.1.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/click/8.1.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/click/8.1.3/compatibility-slim/8.0.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/click/8.1.3/confidence-slim/8.0.4)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-shared-dependencies).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDguMCIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4wIn0=-->
suztomo pushed a commit that referenced this pull request Mar 21, 2023
🤖 I have created a release *beep* *boop*
---


## [3.0.4](https://togithub.com/googleapis/java-shared-dependencies/compare/v3.0.3...v3.0.4) (2022-10-03)


### Dependencies

* Update dependency cachetools to v5 ([#816](https://togithub.com/googleapis/java-shared-dependencies/issues/816)) ([bd2569c](https://togithub.com/googleapis/java-shared-dependencies/commit/bd2569c8c26e177a83cbcf8ed63fed1c3fce2c4b))
* Update dependency certifi to v2022.9.24 ([#818](https://togithub.com/googleapis/java-shared-dependencies/issues/818)) ([5406a0c](https://togithub.com/googleapis/java-shared-dependencies/commit/5406a0ca7e4e2b47f87a39c0fc696fbfd7a6a196))
* Update dependency charset-normalizer to v2.1.1 ([#822](https://togithub.com/googleapis/java-shared-dependencies/issues/822)) ([5c998e4](https://togithub.com/googleapis/java-shared-dependencies/commit/5c998e4d05d47882743cdb5a871a6af728b9d920))
* Update dependency click to v8.1.3 ([#823](https://togithub.com/googleapis/java-shared-dependencies/issues/823)) ([2ad211a](https://togithub.com/googleapis/java-shared-dependencies/commit/2ad211abb259b0fc225303f695a2f0399e19cd66))
* Update dependency com.google.protobuf:protobuf-bom to v3.21.7 ([#837](https://togithub.com/googleapis/java-shared-dependencies/issues/837)) ([d5472aa](https://togithub.com/googleapis/java-shared-dependencies/commit/d5472aa3a98c7a10737b6a9137dba8140087a31b))
* Update dependency gcp-releasetool to v1.8.8 ([#819](https://togithub.com/googleapis/java-shared-dependencies/issues/819)) ([bfef3b0](https://togithub.com/googleapis/java-shared-dependencies/commit/bfef3b0cf05bc200e707dfbf0330d672d824004c))
* Update dependency gcp-releasetool to v1.8.9 ([#846](https://togithub.com/googleapis/java-shared-dependencies/issues/846)) ([533c6a6](https://togithub.com/googleapis/java-shared-dependencies/commit/533c6a6382c2e933b2e87834b5b94913c1dc4943))
* Update dependency google-api-core to v2.10.1 ([#824](https://togithub.com/googleapis/java-shared-dependencies/issues/824)) ([1a5d233](https://togithub.com/googleapis/java-shared-dependencies/commit/1a5d233efa85f1dbd3aa272d2d305d24a35a7576))
* Update dependency google-auth to v2.12.0 ([#825](https://togithub.com/googleapis/java-shared-dependencies/issues/825)) ([cbca860](https://togithub.com/googleapis/java-shared-dependencies/commit/cbca860ae78c7ddf4541ed8b7c057710299162a8))
* Update dependency google-cloud-core to v2.3.2 ([#820](https://togithub.com/googleapis/java-shared-dependencies/issues/820)) ([65a1310](https://togithub.com/googleapis/java-shared-dependencies/commit/65a1310f50ce6914a67cb5e0e4d258f9f4466f11))
* Update dependency google-cloud-storage to v2.5.0 ([#826](https://togithub.com/googleapis/java-shared-dependencies/issues/826)) ([5fd7983](https://togithub.com/googleapis/java-shared-dependencies/commit/5fd7983489b971344e64010c7cfef0a2f60be667))
* Update dependency google-crc32c to v1.5.0 ([#827](https://togithub.com/googleapis/java-shared-dependencies/issues/827)) ([ee9e013](https://togithub.com/googleapis/java-shared-dependencies/commit/ee9e013106173cefbc10563d5d51dd906997c658))
* Update dependency google-resumable-media to v2.4.0 ([#838](https://togithub.com/googleapis/java-shared-dependencies/issues/838)) ([fb02810](https://togithub.com/googleapis/java-shared-dependencies/commit/fb02810c4a975fc75b26d680266ac48f85779a70))
* Update dependency googleapis-common-protos to v1.56.4 ([#821](https://togithub.com/googleapis/java-shared-dependencies/issues/821)) ([49d6423](https://togithub.com/googleapis/java-shared-dependencies/commit/49d64234d57d99c07689d0dd66697bb94d69e958))
* Update dependency importlib-metadata to v4.12.0 ([#832](https://togithub.com/googleapis/java-shared-dependencies/issues/832)) ([33ef522](https://togithub.com/googleapis/java-shared-dependencies/commit/33ef5228cb4fda9ef24e2b4396f970bc5ab67322))
* Update dependency importlib-metadata to v4.13.0 ([#843](https://togithub.com/googleapis/java-shared-dependencies/issues/843)) ([333b61b](https://togithub.com/googleapis/java-shared-dependencies/commit/333b61baf0f42d64699626bbc57315b3a826c3d3))
* Update dependency importlib-metadata to v5 ([#845](https://togithub.com/googleapis/java-shared-dependencies/issues/845)) ([7dc299d](https://togithub.com/googleapis/java-shared-dependencies/commit/7dc299da70133bb0fa9a363816ea804d540edc22))
* Update dependency io.grpc:grpc-bom to v1.49.1 ([#802](https://togithub.com/googleapis/java-shared-dependencies/issues/802)) ([a810f58](https://togithub.com/googleapis/java-shared-dependencies/commit/a810f587a5551e5f36a0b161bc350ebcb636acd5))
* Update dependency io.grpc:grpc-bom to v1.49.2 ([#842](https://togithub.com/googleapis/java-shared-dependencies/issues/842)) ([064a166](https://togithub.com/googleapis/java-shared-dependencies/commit/064a1666dd030c5f9fe35da7ebbda3dad2421427))
* Update dependency jeepney to v0.8.0 ([#833](https://togithub.com/googleapis/java-shared-dependencies/issues/833)) ([d1a5a67](https://togithub.com/googleapis/java-shared-dependencies/commit/d1a5a672089424d3ef9f85ae5d87b669484466e5))
* Update dependency jinja2 to v3.1.2 ([#834](https://togithub.com/googleapis/java-shared-dependencies/issues/834)) ([ad63e98](https://togithub.com/googleapis/java-shared-dependencies/commit/ad63e988d2407a62491a309160e1b87b4cc06d9a))
* Update dependency keyring to v23.9.3 ([#828](https://togithub.com/googleapis/java-shared-dependencies/issues/828)) ([8fed728](https://togithub.com/googleapis/java-shared-dependencies/commit/8fed728e6c84c8cade5bb24a827c558345149cff))
* Update dependency markupsafe to v2.1.1 ([#829](https://togithub.com/googleapis/java-shared-dependencies/issues/829)) ([6a93716](https://togithub.com/googleapis/java-shared-dependencies/commit/6a93716f6f161ced9a08840037bbfe7bfeee0814))
* Update dependency org.threeten:threetenbp to v1.6.2 ([#808](https://togithub.com/googleapis/java-shared-dependencies/issues/808)) ([f03792d](https://togithub.com/googleapis/java-shared-dependencies/commit/f03792d49370e0abbe6f90d37c513920759d6581))
* Update dependency protobuf to v3.20.2 ([#830](https://togithub.com/googleapis/java-shared-dependencies/issues/830)) ([544c20f](https://togithub.com/googleapis/java-shared-dependencies/commit/544c20f9b45fc42ba6b0071153c05034ea08ddc3))
* Update dependency protobuf to v3.20.3 ([#839](https://togithub.com/googleapis/java-shared-dependencies/issues/839)) ([69db6d7](https://togithub.com/googleapis/java-shared-dependencies/commit/69db6d7e56d4673a68e1f49a805635d054856326))
* Update dependency protobuf to v4 ([#817](https://togithub.com/googleapis/java-shared-dependencies/issues/817)) ([d2df74f](https://togithub.com/googleapis/java-shared-dependencies/commit/d2df74f6f456acbcccee7120b0ab164f73b8af93))
* Update dependency pyjwt to v2.5.0 ([#812](https://togithub.com/googleapis/java-shared-dependencies/issues/812)) ([8439533](https://togithub.com/googleapis/java-shared-dependencies/commit/843953365e464c72aa62df1a512a0ca6086a1c37))
* Update dependency requests to v2.28.1 ([#813](https://togithub.com/googleapis/java-shared-dependencies/issues/813)) ([de1d896](https://togithub.com/googleapis/java-shared-dependencies/commit/de1d896da6d7dcaedb520117d675290826d23505))
* Update dependency typing-extensions to v4.3.0 ([#814](https://togithub.com/googleapis/java-shared-dependencies/issues/814)) ([eb8b96b](https://togithub.com/googleapis/java-shared-dependencies/commit/eb8b96b916281aad8f330eb506a7d4be420c4263))
* Update dependency zipp to v3.8.1 ([#815](https://togithub.com/googleapis/java-shared-dependencies/issues/815)) ([74ee8f7](https://togithub.com/googleapis/java-shared-dependencies/commit/74ee8f75795091303236322e6c090a6a2b3f30e5))
* Update gax.version to v2.19.2 ([#847](https://togithub.com/googleapis/java-shared-dependencies/issues/847)) ([63228ac](https://togithub.com/googleapis/java-shared-dependencies/commit/63228ac05cfa27c6ecfee44eb91a8fabb94c5f59))
* Update google.common-protos.version to v2.9.3 ([#803](https://togithub.com/googleapis/java-shared-dependencies/issues/803)) ([cdf3fe6](https://togithub.com/googleapis/java-shared-dependencies/commit/cdf3fe6f7b7abbb9ef0c4a7cd1e4783dbbe0e238))
* Update google.common-protos.version to v2.9.5 ([#831](https://togithub.com/googleapis/java-shared-dependencies/issues/831)) ([62b5617](https://togithub.com/googleapis/java-shared-dependencies/commit/62b5617fa7960a1fdbad5743e44f14e2b6014b47))
* Update google.common-protos.version to v2.9.6 ([#844](https://togithub.com/googleapis/java-shared-dependencies/issues/844)) ([0cd42ae](https://togithub.com/googleapis/java-shared-dependencies/commit/0cd42aee75de5e3ddcde03165620aebae3ce2df0))
* Update google.core.version to v2.8.13 ([#804](https://togithub.com/googleapis/java-shared-dependencies/issues/804)) ([d1b585e](https://togithub.com/googleapis/java-shared-dependencies/commit/d1b585eb836fa55a97ca059426bce15cafcb2b5e))
* Update google.core.version to v2.8.14 ([#805](https://togithub.com/googleapis/java-shared-dependencies/issues/805)) ([3743485](https://togithub.com/googleapis/java-shared-dependencies/commit/37434855f0ec5bef09a8e8b0a062aa1df93da102))
* Update google.core.version to v2.8.15 ([#807](https://togithub.com/googleapis/java-shared-dependencies/issues/807)) ([614586e](https://togithub.com/googleapis/java-shared-dependencies/commit/614586ed92f203901c80ab5539f5c514bb5fe131))
* Update google.core.version to v2.8.16 ([#810](https://togithub.com/googleapis/java-shared-dependencies/issues/810)) ([6d04bef](https://togithub.com/googleapis/java-shared-dependencies/commit/6d04bef8689e87a7505ecb18e556b7d55a05d649))
* Update google.core.version to v2.8.17 ([#835](https://togithub.com/googleapis/java-shared-dependencies/issues/835)) ([5e84cc5](https://togithub.com/googleapis/java-shared-dependencies/commit/5e84cc533778443b798550fe9e3cb0888ad9b8ac))
* Update google.core.version to v2.8.18 ([#840](https://togithub.com/googleapis/java-shared-dependencies/issues/840)) ([203e8b4](https://togithub.com/googleapis/java-shared-dependencies/commit/203e8b4681186f863bc8d2f7e79c3c0102e592b4))
* Update google.core.version to v2.8.19 ([#841](https://togithub.com/googleapis/java-shared-dependencies/issues/841)) ([35bf0dc](https://togithub.com/googleapis/java-shared-dependencies/commit/35bf0dcb1b8e6143fb7750dc3e8eeeb6bfac9a3b))
* Update google.core.version to v2.8.20 ([#848](https://togithub.com/googleapis/java-shared-dependencies/issues/848)) ([047dc3f](https://togithub.com/googleapis/java-shared-dependencies/commit/047dc3f6f1b1a0c27079c8bc07046793c96f8dfc))
* Update iam.version to v1.6.1 ([#806](https://togithub.com/googleapis/java-shared-dependencies/issues/806)) ([b2fc57a](https://togithub.com/googleapis/java-shared-dependencies/commit/b2fc57a99d63554f456f185c136954c688300ab7))
* Update iam.version to v1.6.2 ([#849](https://togithub.com/googleapis/java-shared-dependencies/issues/849)) ([1251c42](https://togithub.com/googleapis/java-shared-dependencies/commit/1251c42fd0e9f31991236a1bfd2ff7010ab22e70))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this pull request Mar 21, 2023
…o v1.34.1 (#823)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.api-client:google-api-client-bom](https://togithub.com/googleapis/google-api-java-client) | `1.34.0` -> `1.34.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api-client:google-api-client-bom/1.34.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api-client:google-api-client-bom/1.34.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api-client:google-api-client-bom/1.34.1/compatibility-slim/1.34.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api-client:google-api-client-bom/1.34.1/confidence-slim/1.34.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/google-api-java-client</summary>

### [`v1.34.1`](https://togithub.com/googleapis/google-api-java-client/releases/v1.34.1)

[Compare Source](https://togithub.com/googleapis/google-api-java-client/compare/v1.34.0...v1.34.1)

##### [1.34.1](https://togithub.com/googleapis/google-api-java-client/compare/v1.34.0...v1.34.1) (2022-05-06)

##### Dependencies

-   downgrade appengine to 1.9.X ([#&#8203;2053](https://togithub.com/googleapis/google-api-java-client/issues/2053)) ([8d9a863](https://togithub.com/googleapis/google-api-java-client/commit/8d9a863033672bb2a0b2d826e0ba6025f437cf96))
-   google-http-client 1.41.8 ([#&#8203;2056](https://togithub.com/googleapis/google-api-java-client/issues/2056)) ([d1e84ac](https://togithub.com/googleapis/google-api-java-client/commit/d1e84acf81141159283d7d33a1cd8221b3aac4fd))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).
suztomo pushed a commit that referenced this pull request Mar 21, 2023
🤖 I have created a release *beep* *boop*
---


## [2.7.0](googleapis/java-core@v2.6.1...v2.7.0) (2022-05-18)


### Features

* **java:** remove native-image-support module ([#820](googleapis/java-core#820)) ([b827e0a](googleapis/java-core@b827e0a))
* next release from main branch is 2.7.0 ([#807](googleapis/java-core#807)) ([2145212](googleapis/java-core@2145212))


### Bug Fixes

* remove native-image-support module from version.txt ([#822](googleapis/java-core#822)) ([8285eee](googleapis/java-core@8285eee))


### Dependencies

* update dependency com.google.api-client:google-api-client-bom to v1.34.1 ([#823](googleapis/java-core#823)) ([58aac09](googleapis/java-core@58aac09))
* update dependency com.google.api:api-common to v2.2.0 ([#827](googleapis/java-core#827)) ([fa4a5db](googleapis/java-core@fa4a5db))
* update dependency com.google.api:gax-bom to v2.17.0 ([#826](googleapis/java-core#826)) ([d1d886d](googleapis/java-core@d1d886d))
* update dependency com.google.api:gax-bom to v2.18.0 ([#829](googleapis/java-core#829)) ([355dd4a](googleapis/java-core@355dd4a))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.2 ([#805](googleapis/java-core#805)) ([c5b4893](googleapis/java-core@c5b4893))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.3 ([#814](googleapis/java-core#814)) ([9621659](googleapis/java-core@9621659))
* update dependency com.google.api.grpc:proto-google-iam-v1 to v1.3.4 ([#825](googleapis/java-core#825)) ([8f907db](googleapis/java-core@8f907db))
* update dependency com.google.auth:google-auth-library-bom to v1.7.0 ([#828](googleapis/java-core#828)) ([0e53f0c](googleapis/java-core@0e53f0c))
* update dependency com.google.cloud:native-image-support to v0.14.0 ([#824](googleapis/java-core#824)) ([bbeb567](googleapis/java-core@bbeb567))
* update dependency com.google.errorprone:error_prone_annotations to v2.13.1 ([#806](googleapis/java-core#806)) ([c4d3e17](googleapis/java-core@c4d3e17))
* update dependency com.google.http-client:google-http-client-bom to v1.41.8 ([#821](googleapis/java-core#821)) ([8c747e1](googleapis/java-core@8c747e1))
* update dependency com.google.protobuf:protobuf-bom to v3.20.1 ([#813](googleapis/java-core#813)) ([f259b41](googleapis/java-core@f259b41))
* update dependency io.grpc:grpc-bom to v1.46.0 ([#815](googleapis/java-core#815)) ([2dc7507](googleapis/java-core@2dc7507))
* update opencensus.version to v0.31.1 ([#819](googleapis/java-core#819)) ([96982b0](googleapis/java-core@96982b0))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants