-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add iam logging #2932
chore: add iam logging #2932
Conversation
Quality Gate failed for 'gapic-generator-java-root'Failed conditions |
Quality Gate passed for 'java_showcase_integration_tests'Issues Measures |
Do you need to add in iam/logging to the proto_path for generation_config.yaml? sdk-platform-java/generation_config.yaml Lines 40 to 43 in f587541
Or is that only for protos with services/ GAPICs. Not too familiar with hermetic build, going to default to Blake's review. |
No need to add a proto_path because logging is a nested directory in I removed the special case in |
@@ -5,7 +5,7 @@ | |||
"api_description": "Manages access control for Google Cloud Platform resources", | |||
"client_documentation": "https://cloud.google.com/java/docs/reference/proto-google-iam-v1/latest/overview", | |||
"release_level": "stable", | |||
"transport": "grpc", | |||
"transport": "both", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know why the transport changed? Is it because this PR #2890?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, now iam/v2
is used to get the transport.
In this PR:
google/iam/v1
.