Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename requirements.in to requirements.txt. #2619

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

blakeli0
Copy link
Collaborator

@blakeli0 blakeli0 commented Apr 3, 2024

Rename requirements.in to requirements.txt. It is a more standard way to manage Python dependencies, it can be recognized automatically by some IDEs.

Add environment setup section to README for running hermetic build scripts.

… setup before running hermetic build scripts.
@blakeli0 blakeli0 requested a review from a team as a code owner April 3, 2024 20:41
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 3, 2024
@@ -10,6 +10,8 @@ configuration file.
- Java runtime environment (8 or above)
- Apache Maven (used in formatting source code)
- Python (3.11.6 or above)
- Docker
- Git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need git?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some post processing scripts perform git operations, I don't think we should continue this way and should refactor it in the future, but currently we do.

@blakeli0 blakeli0 closed this Apr 5, 2024
@blakeli0 blakeli0 reopened this Apr 5, 2024
@blakeli0 blakeli0 mentioned this pull request Apr 5, 2024
Copy link

sonarqubecloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@blakeli0 blakeli0 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 5, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit ad55967 into main Apr 5, 2024
43 of 45 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the refactor-docs branch April 5, 2024 23:22
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants