-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rename requirements.in to requirements.txt. #2619
Conversation
… setup before running hermetic build scripts.
@@ -10,6 +10,8 @@ configuration file. | |||
- Java runtime environment (8 or above) | |||
- Apache Maven (used in formatting source code) | |||
- Python (3.11.6 or above) | |||
- Docker | |||
- Git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need git
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some post processing scripts perform git operations, I don't think we should continue this way and should refactor it in the future, but currently we do.
Quality Gate passed for 'gapic-generator-java-root'Issues Measures |
Quality Gate passed for 'java_showcase_integration_tests'Issues Measures |
Rename requirements.in to requirements.txt. It is a more standard way to manage Python dependencies, it can be recognized automatically by some IDEs.
Add environment setup section to README for running hermetic build scripts.