fix: Move direct path misconfiguration log to before creating the first channel

[blakeli0]

Fixes #2423
The root cause of the issue is that logDirectPathMisconfig() is called in the builder of InstantiatingGrpcChannelProvider, which could be called multiple times before it is fully instantiated. We should only call logDirectPathMisconfig() right before createChannel() which creates the first channel.

We can not move it to before createSingleChannel() because it is used for resizing channel regularly after a client is initialized, and we only want to log direct path misconfiguration once.

[lqiu96]

Thoughts on adding test which creates a InstantiatingGrpcChannelProvider, changes a property in the builder with it still misconfigured, and recreates it? Essentially runs InstantiatingGrpcChannelProvider.{newBuilder|toBuilder()}.build() twice. The FakeLogHandler should only show the misconfiguration log once since the logging should occur prior to channel creation and on .build().

Might be beneficial so we don't accidentally refactor logDirectPathMisconfig() into the channel creation logic in the future.

[blakeli0]

Thoughts on adding test which creates a InstantiatingGrpcChannelProvider, changes a property in the builder with it still misconfigured, and recreates it? Essentially runs InstantiatingGrpcChannelProvider.{newBuilder|toBuilder()}.build() twice. The FakeLogHandler should only show the misconfiguration log once since the logging should occur prior to channel creation and on .build().

Thanks! Added a test case that calling builder should not log anything.

[sonarqubecloud]

Quality Gate passed for 'gapic-generator-java-root'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarqubecloud]

Quality Gate passed for 'java_showcase_integration_tests'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud