Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor test utilities #2013

Merged
merged 1 commit into from
Sep 20, 2023
Merged

chore: refactor test utilities #2013

merged 1 commit into from
Sep 20, 2023

Conversation

JoeWang1127
Copy link
Collaborator

@JoeWang1127 JoeWang1127 commented Sep 20, 2023 •
edited
Loading

In this PR:

  • Move testing utility functions to library_generation/test/test_utilities.sh.

Follow up of #2004 (comment)

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Sep 20, 2023
JoeWang1127
JoeWang1127 commented Sep 20, 2023
View reviewed changes
library_generation/test/generate_library_integration_test.sh
library_generation_dir="${script_dir}"/..
output_folder="$(get_output_folder)"
source "${script_dir}/test_utilities.sh"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now integration test script only source test_utilities.sh

showcase/scripts/generate_showcase.sh
readonly perform_cleanup=$1

cd "${SCRIPT_DIR}"
mkdir -p "${SCRIPT_DIR}/output"

# takes a versions.txt file and returns its version
get_version_from_versions_txt() {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is only used in generating showcase, so move it here.

@sonarqubecloud
Copy link

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@JoeWang1127 JoeWang1127 marked this pull request as ready for review September 20, 2023 14:23
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner September 20, 2023 14:23
@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2023
@JoeWang1127 JoeWang1127 merged commit 1f4aa27 into main Sep 20, 2023
41 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/refactor-test-utilities branch September 20, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@diegomarquezp diegomarquezp Awaiting requested review from diegomarquezp

Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeWang1127 @blakeli0