Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spring): switch camelcase conversion logic to use JavaStyle #1245

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

emmileaf
Copy link
Contributor

@emmileaf emmileaf commented Jan 12, 2023

This PR switches camelcase handling to use align with logic used in generating client libraries, e.g. here. However, it introduces no updates to golden tests for the spring composers, and my local test to regenerate GoogleCloudPlatform/spring-cloud-gcp#1449 using this branch also showed no diff.

I think spring-cloud-gcp enforces stricter checkstyle rules (fail on warning) than what is used for the client libraries, so a corresponding change has been made on that side to suppress this for a number of files with abbreviation handling edge cases: GoogleCloudPlatform/spring-cloud-gcp#1455

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jan 12, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@emmileaf emmileaf added the spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch. label Jan 12, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes. Although no difference in generated code is made, it's good to be in sync with client library for maintenance.

@emmileaf emmileaf merged commit a3d86b0 into autoconfig-gen-draft2 Jan 13, 2023
@emmileaf emmileaf deleted the spring-checkstyle-patch branch January 13, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants