Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ggj] Add .circleci/config.yml #1

Merged
merged 1 commit into from
May 18, 2020
Merged

Conversation

miraleung
Copy link
Contributor

No description provided.

@miraleung miraleung merged commit 35560b4 into master May 18, 2020
vam-google added a commit to vam-google/gapic-generator-java that referenced this pull request Apr 22, 2021
 This is as minimal of a PR that I could make stuch that:
 1) It compiles and tests run single composer plus minimal
 2) All the key changes are present (abstract/grpc class, comment composer, class names, golden files move)

 I had to add a few quite ugly and artificial   constructs:
 fake `ClassComposer` under `composer` package which simply extends `composer.common.Composer` to void changing the rest of the classes
 put back static methods in `ClassNames` and `StubCommentComposer` and `TestProtoLoaderUtil` (for the same reasons as above). All of those chagnes are marked with `// TODO: remove after Pre-DIREGAPIC refactoring is fully merged` statement.
vam-google added a commit that referenced this pull request May 18, 2021
* chore: Pre-DIREGAPIC Refactoring #1

 This is as minimal of a PR that I could make stuch that:
 1) It compiles and tests run single composer plus minimal
 2) All the key changes are present (abstract/grpc class, comment composer, class names, golden files move)

 I had to add a few quite ugly and artificial   constructs:
 fake `ClassComposer` under `composer` package which simply extends `composer.common.Composer` to void changing the rest of the classes
 put back static methods in `ClassNames` and `StubCommentComposer` and `TestProtoLoaderUtil` (for the same reasons as above). All of those chagnes are marked with `// TODO: remove after Pre-DIREGAPIC refactoring is fully merged` statement.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant