Skip to content

Commit

Permalink
fix: update the return type of setWaitTimeout for convience (#1751)
Browse files Browse the repository at this point in the history
Thank you for opening a Pull Request! For general contributing guidelines, please refer to [contributing guide](https://togithub.com/googleapis/gapic-generator-java/blob/main/CONTRIBUTING.md)

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/gapic-generator-java/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️
  • Loading branch information
mutianf authored Jun 6, 2023
1 parent 9345240 commit f1927a5
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
6 changes: 6 additions & 0 deletions gax-java/gax/clirr-ignored-differences.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,10 @@
<className>com/google/api/gax/paging/Page</className>
<method>* stream*(*)</method>
</difference>
<difference>
<differenceType>7006</differenceType>
<className>com/google/api/gax/rpc/ServerStreamingCallSettings$Builder</className>
<method>*setWaitTimeout*</method>
<to>com.google.api.gax.rpc.ServerStreamingCallSettings$Builder</to>
</difference>
</differences>
Original file line number Diff line number Diff line change
Expand Up @@ -299,8 +299,9 @@ public Duration getWaitTimeout() {
* Set the maximum amount of time to wait for the next message from the server. {@link
* Duration#ZERO} disables the check for abandoned streams.
*/
public void setWaitTimeout(@Nonnull Duration waitTimeout) {
public Builder<RequestT, ResponseT> setWaitTimeout(@Nonnull Duration waitTimeout) {
this.waitTimeout = waitTimeout;
return this;
}

@Override
Expand Down

0 comments on commit f1927a5

Please sign in to comment.