Skip to content

Commit

Permalink
fix: graalvm missing build time class when using protobuf 4.x (#3438)
Browse files Browse the repository at this point in the history
In case of protobuf 4+ need to include protobuf.Runtime in classes
initialized at build time as that is used to determine protobuf version
for graalvm.

Tested, temporarily bumped protobuf dependency to 4.28.1 without
including Runtime in build time class list. Received error:

```
Error: Classes that should be initialized at run time got initialized during image building:
 com.google.protobuf.RuntimeVersion was unintentionally initialized at build time. To see why com.google.protobuf.RuntimeVersion got initialized use --trace-class-initialization=com.google.protobuf.RuntimeVersion
```

Updated to include Runtime and received passing [native showcase
tests](https://github.com/googleapis/sdk-platform-java/actions/runs/12205342463/job/34052473211?pr=3438)
  • Loading branch information
ldetmer authored Dec 6, 2024
1 parent 66b85da commit f0236cf
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ Args = --enable-url-protocols=https,http \
org.junit.platform.engine.TestTag,\
com.google.api.gax.core.GaxProperties,\
com.google.common.base.Platform,\
com.google.common.base.Platform$JdkPatternCompiler \
com.google.common.base.Platform$JdkPatternCompiler,\
com.google.protobuf.RuntimeVersion \
--features=com.google.api.gax.nativeimage.OpenCensusFeature,\
com.google.api.gax.nativeimage.GoogleJsonClientFeature \
--add-modules=jdk.httpserver

0 comments on commit f0236cf

Please sign in to comment.