-
Notifications
You must be signed in to change notification settings - Fork 53
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: generate pr description with repo level change (#3182)
In this PR: - Generate PR description if config has repo level change without qualified commit. Context: googleapis/java-storage#2672 doesn't generate PR description even though the generator version and librararies-bom version are changed.
- Loading branch information
1 parent
46b2b6a
commit edd2168
Showing
4 changed files
with
131 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
...ation/test/resources/goldens/repo_level_and_no_qualified_commit_pr_description-golden.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
This pull request is generated with proto changes between [googleapis/googleapis@3b6f144](https://github.com/googleapis/googleapis/commit/3b6f144d47b0a1d2115ab2445ec06e80cc324a44) (exclusive) and [googleapis/googleapis@0cea717](https://github.com/googleapis/googleapis/commit/0cea7170404bec3d994f43db4fa292f5034cbe9a) (inclusive). | ||
|
||
BEGIN_COMMIT_OVERRIDE | ||
BEGIN_NESTED_COMMIT | ||
fix(deps): update the Java code generator (gapic-generator-java) to 1.2.3 | ||
END_NESTED_COMMIT | ||
BEGIN_NESTED_COMMIT | ||
chore: update the libraries_bom version to 2.3.4 | ||
END_NESTED_COMMIT | ||
END_COMMIT_OVERRIDE |
5 changes: 5 additions & 0 deletions
5
library_generation/test/resources/goldens/repo_level_only_pr_description-golden.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
BEGIN_COMMIT_OVERRIDE | ||
BEGIN_NESTED_COMMIT | ||
fix(deps): update the Java code generator (gapic-generator-java) to 1.2.3 | ||
END_NESTED_COMMIT | ||
END_COMMIT_OVERRIDE |