Skip to content

Commit

Permalink
chore: Add Clirr exemptions for Protobuf 4.27.4 runtime (#3188)
Browse files Browse the repository at this point in the history
Clirr is flagging a bunch of 7006 Method Return Type changed errors. The
Protoc generated changes are source code compatible and should ignore
these errors in our generated code.

See [this
doc](https://docs.google.com/spreadsheets/d/1qEzUWLougtiqh0ocRaG4e8w12pr89o0T_tQvB6YDStE/edit?pli=1&gid=0#gid=0)
for more information. After adding all the Clirr checks exemptions in
this PR to the downstream handwritten libraries, we are no longer seeing
an Clirr failures.
  • Loading branch information
lqiu96 authored and ldetmer committed Sep 17, 2024
1 parent 8efc704 commit 9f27590
Showing 1 changed file with 61 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,66 @@
<differenceType>7012</differenceType>
<className>{{proto_path}}/*OrBuilder</className>
<method>boolean has*(*)</method>
</difference>
<!-- The following 7006 exemptions are related to Protobuf 4.27.4 upgrade -->
<difference>
<differenceType>7006</differenceType>
<className>{{proto_path}}/**</className>
<method>* getDefaultInstanceForType()</method>
<to>**</to>
</difference>
<difference>
<differenceType>7006</differenceType>
<className>{{proto_path}}/**</className>
<method>* addRepeatedField(*)</method>
<to>**</to>
</difference>
<difference>
<differenceType>7006</differenceType>
<className>{{proto_path}}/**</className>
<method>* clear()</method>
<to>**</to>
</difference>
<difference>
<differenceType>7006</differenceType>
<className>{{proto_path}}/**</className>
<method>* clearField(*)</method>
<to>**</to>
</difference>
<difference>
<differenceType>7006</differenceType>
<className>{{proto_path}}/**</className>
<method>* clearOneof(*)</method>
<to>**</to>
</difference>
<difference>
<differenceType>7006</differenceType>
<className>{{proto_path}}/**</className>
<method>* clone()</method>
<to>**</to>
</difference>
<difference>
<differenceType>7006</differenceType>
<className>{{proto_path}}/**</className>
<method>* mergeUnknownFields(*)</method>
<to>**</to>
</difference>
<difference>
<differenceType>7006</differenceType>
<className>{{proto_path}}/**</className>
<method>* setField(*)</method>
<to>**</to>
</difference>
<difference>
<differenceType>7006</differenceType>
<className>{{proto_path}}/**</className>
<method>* setRepeatedField(*)</method>
<to>**</to>
</difference>
<difference>
<differenceType>7006</differenceType>
<className>{{proto_path}}/**</className>
<method>* setUnknownFields(*)</method>
<to>**</to>
</difference>{% endfor %}
</differences>

0 comments on commit 9f27590

Please sign in to comment.