-
Notifications
You must be signed in to change notification settings - Fork 53
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: re-enable checkstyle in sdk-platform-java-config (#2335)
The checkstyle was initially disabled to address the following error when executing `mvn clean install`: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.3.1:check (checkstyle) on project sdk-platform-java-config: Failed during checkstyle execution: Unable to find configuration file at location: license-checks.xml: Could not find resource 'license-checks.xml'. -> [Help 1] ``` However, since this artifact is meant to be used as a parent for downstream libraries, there is a risk that the `checkstyle.skip` property will be inherited by child poms in the future. This may cause checkstyle to be unintentionally disabled.
- Loading branch information
Showing
3 changed files
with
25 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
^/\*$ | ||
^ \* Copyright \d\d\d\d,? Google (Inc\.|LLC)$ | ||
^ \*$ | ||
^ \* Licensed under the Apache License, Version 2\.0 \(the "License"\);$ | ||
^ \* you may not use this file except in compliance with the License\.$ | ||
^ \* You may obtain a copy of the License at$ | ||
^ \*$ | ||
^ \*[ ]+https?://www.apache.org/licenses/LICENSE-2\.0$ | ||
^ \*$ | ||
^ \* Unless required by applicable law or agreed to in writing, software$ | ||
^ \* distributed under the License is distributed on an "AS IS" BASIS,$ | ||
^ \* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied\.$ | ||
^ \* See the License for the specific language governing permissions and$ | ||
^ \* limitations under the License\.$ | ||
^ \*/$ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<?xml version="1.0"?> | ||
<!DOCTYPE module PUBLIC | ||
"-//Puppy Crawl//DTD Check Configuration 1.3//EN" | ||
"http://www.puppycrawl.com/dtds/configuration_1_3.dtd"> | ||
<module name="Checker"> | ||
<module name="RegexpHeader"> | ||
<property name="fileExtensions" value="java"/> | ||
<property name="headerFile" value="${checkstyle.header.file}"/> | ||
</module> | ||
</module> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters