-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: android version now correctly builds as a number #1770
fix: android version now correctly builds as a number #1770
Conversation
Thanks @JaccoGoris 🔥 @chingor13, what needs to be done before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me, but the test needs to be fixed
@JaccoGoris, can you take a look at the test? 🫣 |
Didn't see that the snapshot was wrong. I ran the tests but about half of them fail locally with graphql errors, http issues and api rate limits. So I missed my broken test :D Added a fix, hoping it works this time! |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1767 🦕