Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Every release adds a new comment to the release PR (instead of a single comment with the list of all releases made) #2285

Closed
niieani opened this issue May 10, 2024 · 0 comments · Fixed by #2286 or #2303
Closed

Every release adds a new comment to the release PR (instead of a single comment with the list of all releases made) #2285

niieani opened this issue May 10, 2024 · 0 comments · Fixed by #2286 or #2303
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@niieani
Copy link
Contributor

niieani commented May 10, 2024 •
edited
Loading

Environment details

  • OS: macOS 14.4.1 (23E224)
  • Node.js version: v21.1.0
  • npm version: 10.7.0
  • release-please version: 16.10.2

Steps to reproduce

  1. use a monorepo configuration with node-workspace
  2. make changes to multiple packages
  3. merge the release-please-generated PR
  4. for every package released, you'll see a comment made to the PR

Example:

Screenshot 2024-05-10 at 10 19 23

Ideally, there would only be one comment with a list of all the releases.

Additionally, as you can se above, if there's a non-ASCII character in the name of the release, the link embedded in the comment is nasty.

This is an easy fix, I'll make a PR fixing this.
@niieani niieani added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 10, 2024
niieani added a commit to niieani/release-please that referenced this issue May 10, 2024
@niieani
feat: issue a combined PR comment for all releases
8800d05 
also fixes the release URL with non-ascii characters

fixes googleapis#2285
@niieani niieani mentioned this issue May 10, 2024
Merged
4 tasks
chingor13 added a commit that referenced this issue Jun 6, 2024
@niieani @chingor13
feat: issue a combined PR comment for all releases (#2286)
719fdf5 
also fixes the release URL with non-ascii characters

fixes #2285

Co-authored-by: Jeff Ching <[email protected]>
@release-please release-please bot mentioned this issue Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@chingor13 @niieani