Skip to content

Commit

Permalink
fix: respect signoff in manifest config (#2334)
Browse files Browse the repository at this point in the history
Signed-off-by: Ketil Gjerde <[email protected]>
Co-authored-by: Jeff Ching <[email protected]>
  • Loading branch information
mysteq and chingor13 authored Sep 11, 2024
1 parent a41d137 commit eb968c8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
5 changes: 5 additions & 0 deletions schemas/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,10 @@
]
}
},
"signoff": {
"description": "Text to be used as Signed-off-by in the commit.",
"type": "string"
},
"group-pull-request-title-pattern": {
"description": "When grouping multiple release pull requests use this pattern for the title.",
"type": "string"
Expand Down Expand Up @@ -431,6 +435,7 @@
"last-release-sha": true,
"always-link-local": true,
"plugins": true,
"signoff": true,
"group-pull-request-title-pattern": true,
"release-search-depth": true,
"commit-search-depth": true,
Expand Down
5 changes: 2 additions & 3 deletions src/manifest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ export interface ReleaserConfig {
releaseLabels?: string[];
extraLabels?: string[];
initialVersion?: string;
signoff?: string;

// Changelog options
changelogSections?: ChangelogSection[];
Expand Down Expand Up @@ -161,7 +160,6 @@ interface ReleaserConfigJson {
'changelog-sections'?: ChangelogSection[];
'release-as'?: string;
'skip-github-release'?: boolean;
signoff?: string;
draft?: boolean;
prerelease?: boolean;
'draft-pull-request'?: boolean;
Expand Down Expand Up @@ -255,6 +253,7 @@ export interface ManifestConfig extends ReleaserConfigJson {
'last-release-sha'?: string;
'always-link-local'?: boolean;
plugins?: PluginType[];
signoff?: string;
'group-pull-request-title-pattern'?: string;
'release-search-depth'?: number;
'commit-search-depth'?: number;
Expand Down Expand Up @@ -1372,7 +1371,6 @@ function extractReleaserConfig(
skipSnapshot: config['skip-snapshot'],
initialVersion: config['initial-version'],
excludePaths: config['exclude-paths'],
signoff: config['signoff'],
};
}

Expand Down Expand Up @@ -1417,6 +1415,7 @@ async function parseConfig(
separatePullRequests: config['separate-pull-requests'],
groupPullRequestTitlePattern: config['group-pull-request-title-pattern'],
plugins: config['plugins'],
signoff: config['signoff'],
labels: configLabel?.split(','),
releaseLabels: configReleaseLabel?.split(','),
snapshotLabels: configSnapshotLabel?.split(','),
Expand Down

0 comments on commit eb968c8

Please sign in to comment.