Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase timeout of delay in hmac get test #2457

Merged
merged 1 commit into from
May 15, 2024

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2456 🦕

@ddelgrosso1 ddelgrosso1 marked this pull request as ready for review May 6, 2024 13:45
@ddelgrosso1 ddelgrosso1 requested review from a team as code owners May 6, 2024 13:45
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels May 6, 2024
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 6, 2024
@@ -3110,7 +3109,6 @@ describe('storage', function () {
});

it('should get metadata for an HMAC key', async function () {
this.retries(3);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer necessary as this.retries(3) is set at the outermost level.

Copy link

@danielduhh danielduhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im guessing this issue exists in other languages. What are other folks doing to mitigate this?

@ddelgrosso1
Copy link
Contributor Author

@danielduhh added #2461

@ddelgrosso1 ddelgrosso1 merged commit f2e1e0c into googleapis:main May 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage HMAC keys: should get metadata for an HMAC key failed
2 participants