feat(observability): add tracing spans to Session #2121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
odeke-em
force-pushed
the
trace-Session
branch
5 times, most recently
from
909108d to
d670cd6
Compare
This change adds tracing spans to Session for methods: * create * getMetadata * keepAlive and corresponding tests. Updates googleapis#2079 Built from PR googleapis#2087 Updates googleapis#2114
odeke-em
force-pushed
the
trace-Session
branch
from
d670cd6 to
62a9ba8
Compare
| @@ -431,6 +454,10 @@ export class Session extends common.GrpcServiceObject { | |||
| optionsOrCallback?: CallOptions | KeepAliveCallback, | |||
| cb?: KeepAliveCallback | |||
| ): void | Promise<KeepAliveResponse> { | |||
| // NOTE: Please do not trace Ping as it gets quite spammy | |||
There was a problem hiding this comment.
No need for this comment, this comment was already added in the caller of this method.
| resp.databaseRole = resp.creatorRole; | ||
| delete resp.creatorRole; | ||
| this.metadata = resp; | ||
|
|
There was a problem hiding this comment.
remove for this method. We dont need it for now. Can add later if we need
| return; | ||
| } | ||
| const q = {opts: database.observabilityConfig}; | ||
| return startTrace('Session.create', q, span => { |
There was a problem hiding this comment.
I think we dont need this as well, as we dont use single session creation , instead we use batch create session
|
Alright, thanks @surbhigarg92! Sure we can put it on ice and move onto others! |
|
Deemed as unnecessary! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds tracing spans to Session for methods:
and corresponding tests.
Updates #2079
Built from PR #2087
Updates #2114