Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): add emulator support for the admin client autogenerated API samples #1994

Merged
merged 57 commits into from
Feb 28, 2024
Merged

feat(spanner): add emulator support for the admin client autogenerated API samples #1994

merged 57 commits into from
Feb 28, 2024

Conversation

alkatrivedi
Copy link
Contributor

@alkatrivedi alkatrivedi commented Feb 13, 2024 •
edited by surbhigarg92
Loading

This PR introduces emulator support for the API samples, which are using admin client autogenerated methods.

Sample usage

For Instance samples:

const {Spanner} = require('@google-cloud/spanner');
const spanner = new Spanner({
    projectId: projectId,
  });
 const instanceAdminClient = spanner.get_instance_admin_client();

For Database samples:

const {Spanner} = require('@google-cloud/spanner');
const spanner = new Spanner({
    projectId: projectID,
  });
const databaseAdminClient = spanner.get_database_admin_client();

@alkatrivedi alkatrivedi requested review from a team as code owners February 13, 2024 08:15
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/nodejs-spanner API. samples Issues that are directly related to samples. labels Feb 13, 2024
@alkatrivedi alkatrivedi changed the title feat(spanner): add emulator support for the apis samples using admin client autogenerated methods feat(spanner): add emulator support for the admin client autogenerated API samples Feb 13, 2024
olavloite
olavloite reviewed Feb 14, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
olavloite
olavloite reviewed Feb 14, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot removed the size: s Pull request size is small. label Feb 23, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Feb 27, 2024
olavloite
olavloite approved these changes Feb 27, 2024
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
system-test/spanner.ts Outdated

it('should list the instances', async () => {
assert(projectId);
const [operation] = await instanceAdminClient.listInstances({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
const [operation] = await instanceAdminClient.listInstances({
const [instances] = await instanceAdminClient.listInstances({

@surbhigarg92 surbhigarg92 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024
@surbhigarg92 surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@surbhigarg92 surbhigarg92 added the automerge Merge the pull request once unit tests and other checks pass. label Feb 28, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit e2fe5b7 into googleapis:main Feb 28, 2024
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 28, 2024
@release-please release-please bot mentioned this pull request Feb 28, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 4, 2024
@release-please
chore(main): release 7.5.0 (#2002)
c2ab7bf 
🤖 I have created a release *beep* *boop*
---


## [7.5.0](https://togithub.com/googleapis/nodejs-spanner/compare/v7.4.0...v7.5.0) (2024-03-04)


### Features

* **spanner:** Add emulator support for the admin client autogenerated API samples ([#1994](https://togithub.com/googleapis/nodejs-spanner/issues/1994)) ([e2fe5b7](https://togithub.com/googleapis/nodejs-spanner/commit/e2fe5b748c3077078fa43e4bfa427fef603656a9))


### Bug Fixes

* Revert untyped param type feature ([#2012](https://togithub.com/googleapis/nodejs-spanner/issues/2012)) ([49fa60d](https://togithub.com/googleapis/nodejs-spanner/commit/49fa60dd0735fe66db33f7b9137dba0821eb5184))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@alkatrivedi alkatrivedi deleted the admin-emulator-support branch March 5, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

@olavloite olavloite olavloite approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alkatrivedi @olavloite @surbhigarg92 @yoshi-kokoro