Skip to content

Commit

Permalink
Address review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
odeke-em committed Oct 21, 2024
1 parent 4ecc6b4 commit aa794ac
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion observability-test/spanner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ describe('EndToEnd', () => {
database.formattedName_
);
await database.runTransactionAsync(async transaction => {
const [rows] = await transaction!.run('SELECT 1');
await transaction!.run('SELECT 1');
});

traceExporter.forceFlush();
Expand Down
2 changes: 1 addition & 1 deletion src/database.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3395,7 +3395,7 @@ class Database extends common.GrpcServiceObject {
try {
return await runner.run();
} catch (e) {
setSpanError(span, e as Error);
setSpanErrorAndException(span, e as Error);
throw e;
} finally {
span.end();
Expand Down

0 comments on commit aa794ac

Please sign in to comment.