-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add soft delete feature #2403
Merged
Merged
Changes from 20 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
26326a4
feat: add soft delete feature
JesseLovelace 407af36
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 22ae88d
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] bd4bb67
Merge branch 'softdel' of https://github.com/googleapis/java-storage …
gcf-owl-bot[bot] d77aa58
add softDeleteTime and hardDeleteTime object fields
JesseLovelace a888e80
Merge branch 'softdel' of github.com:googleapis/java-storage into sof…
JesseLovelace 2a85a65
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 4f1b6de
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] fd22008
add new fields to field tests
JesseLovelace 7142bcb
Merge branch 'softdel' of github.com:googleapis/java-storage into sof…
JesseLovelace 0f837d3
clirr ignore
JesseLovelace c2884aa
remove debug comments
JesseLovelace ac6022e
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 1c363ff
Merge branch 'main' into softdel
JesseLovelace dbe0d92
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] fb88608
add softdeletetime and harddeletetime to grpc codec
JesseLovelace 04975fc
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 1de29b8
fix read mask test
JesseLovelace c98d8c7
Merge branch 'softdel' of github.com:googleapis/java-storage into sof…
JesseLovelace 3a4a00f
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] b3d70db
fix style issues
JesseLovelace 7986f9c
Merge branch 'softdel' of github.com:googleapis/java-storage into sof…
JesseLovelace a93e162
Merge branch 'main' into softdel
JesseLovelace 5a744ca
updates to apiary library
JesseLovelace 0b8fe3f
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] be3e975
Merge branch 'main' into softdel
JesseLovelace 5e65c40
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 938e00c
fix read mask test
JesseLovelace 8f38221
Merge branch 'softdel' of github.com:googleapis/java-storage into sof…
JesseLovelace 68ce8c0
fix typo
JesseLovelace File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC this is needed because you can't specify generation on Bucket.get() that exists today; Would recommend using BlobId instead of adding Long generation overload.
Do you think this is hard requirement to support this feature since there's
storage.get(BlobId..)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would feel pretty weird that soft deleted would become the only state an object can be in where you can get it from
Storage
but can't get it from theBucket
that the object lives in.I also think using
BlobId
here would feel weird, because you're already calling from a Bucket, so it's weird to have to supply the same Bucket name into the BlobId. There are no other methods inBucket.java
that have aBlobId
in the signatureThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bleh, missed that bucket name is also part of BlobId. thanks.
We haven't had generation in Bucket.get() at all which is required for version enabled buckets, that's why i asked this question as well.
For the sake of discussion, WDYT about having generation under BlobGetOption's? It's a query paramter just like IfGenerationMatch etc.