feat: add object retention feature #2277
Conversation
product-auto-label
bot
added
size: l
google-cloud-storage/src/main/java/com/google/cloud/storage/BlobInfo.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/BlobInfo.java
Outdated
Show resolved
Hide resolved
|
|
||
| public static Builder newBuilder() { | ||
| return new Builder(); | ||
| } |
There was a problem hiding this comment.
I can't remember, do we usually do toBuilder() for the nested model classes or only the top level ones?
google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/Storage.java
Outdated
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/UnifiedOpts.java
Show resolved
Hide resolved
google-cloud-storage/src/main/java/com/google/cloud/storage/UnifiedOpts.java
Show resolved
Hide resolved
| // Create a bucket with object retention enabled | ||
| storage.create( | ||
| BucketInfo.newBuilder(bucketName).build(), BucketTargetOption.enableObjectRetention(true)); | ||
|
|
||
| try { | ||
| Bucket remoteBucket = storage.get(bucketName); |
There was a problem hiding this comment.
If interested, you could use the TemporaryBucket helper to create and automatically cleanup the bucket. Example of this
| @@ -238,6 +246,11 @@ private StorageObject blobInfoEncode(BlobInfo from) { | |||
| from.getRetentionExpirationTimeOffsetDateTime(), | |||
| dateTimeCodec::encode, | |||
| to::setRetentionExpirationTime); | |||
| if (from.getRetention() == null) { | |||
| to.setRetention(Data.nullOf(StorageObject.Retention.class)); | |||
There was a problem hiding this comment.
What was the conclusion on detecting if a user set retention to null vs. it not being modified?
There was a problem hiding this comment.
It doesn't work, due to the modified fields not being passed along to the final patch call. I talked to ben and we agreed to just do it this way, there's precedent for it in the logging encoding
There was a problem hiding this comment.
Thanks for clarifying, is this value mutable once set?
There was a problem hiding this comment.
Only certain cases work (i.e. going from Unlocked to Locked, reducing the retainUntilTime on an unlocked policy, and setting to null), and you have to pass in overrideUnlockedRetention for any of those cases to work, but yes
BenWhitehead
dismissed
their stale review
No longer blocking, but tests can't pass yet so not approving
|
The current failure is just because the test project isn't allowlisted yet, it should be soon |
JesseLovelace
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
JesseLovelace
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
Adds the object retention feature and tests