fix!: initialize should be protected #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
@thiagotnunes It would be good to include this change in the release with the other breaking changes. |
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
=========================================
Coverage 84.04% 84.04%
+ Complexity 2540 2537 -3
=========================================
Files 140 140
Lines 13891 13891
Branches 1329 1329
=========================================
Hits 11675 11675
Misses 1672 1672
Partials 544 544
Continue to review full report at Codecov.
|
thiagotnunes
approved these changes
Oct 22, 2020
Merged
ansh0l
pushed a commit
to ansh0l/java-spanner
that referenced
this pull request
Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#3719 Changes: feat(spanner/admin/database): add CMEK fields to backup and database PiperOrigin-RevId: 358725120 Source-Link: googleapis/googleapis@f829b13 chore: release gapic-generator-java v0.0.21 with gapic_metadata.json support Committer: @miraleung PiperOrigin-RevId: 358516065 Source-Link: googleapis/googleapis@af8f71d chore: update rules_gapic to v0.4.0 (fixes build_gen for Java packages) Committer: @miraleung PiperOrigin-RevId: 358464992 Source-Link: googleapis/googleapis@ab95a4f chore: update maps/routespreferred Gapic schema to 2.0 Committer: @miraleung PiperOrigin-RevId: 358452585 Source-Link: googleapis/googleapis@fce32c0 feat(area120/tables): Added ListWorkspaces, GetWorkspace, BatchDeleteRows APIs. PiperOrigin-RevId: 358406243 Source-Link: googleapis/googleapis@151bfba
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/d9079f8e-3fa1-44e6-b6d8-65a7341e9be2/targets - [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.) Source-Link: googleapis/synthtool@5d3c52f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AbstractLazyInitializer#initialize()method should beprotected.