chore: make state field volatile in AsyncResultSetImpl #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark the `state` field in `AsyncResultSetImpl` volatile, as it is inspected by different threads.
product-auto-label
bot
added
size: xs
product-auto-label
bot
added
size: s
|
The failure in |
rahul2393
approved these changes
Dec 13, 2024
surbhigarg92
pushed a commit
to surbhigarg92/java-spanner
that referenced
this pull request
Dec 26, 2024
* chore: make state field volatile in AsyncResultSetImpl Mark the `state` field in `AsyncResultSetImpl` volatile, as it is inspected by different threads. * fix: protect writes with monitor --------- Co-authored-by: rahul2393 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the
statefield inAsyncResultSetImplvolatile, as it is inspected by different threads. Also make sure the state is only updated while in asynchronized (monitor)block.Fixes #3484
Fixes #3481
Fixes #3479