Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spanner): add environment variable for enabling rw multiplexed sessions #3539

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

chore(spanner): add environment variable for enabling rw multiplexed sessions #3539

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
d56908b
chore(spanner): add environment variable for enabling read-write mult…
harshachinta Dec 10, 2024
ff6f80e
chore(spanner): update mock spanner to not count the beginTransaction…
harshachinta Dec 16, 2024
3242fae
chore(spanner): skip tests if mur for rw is enabled
harshachinta Dec 17, 2024
70b056e
Merge branch 'main' into mux-rw-env
harshachinta Dec 17, 2024
d57fe74
chore(spanner): lint
harshachinta Dec 17, 2024
dfd3812
chore(spanner): fix tests
harshachinta Dec 17, 2024
3b67313
chore(spanner): fix tests
harshachinta Dec 18, 2024
8a3b6fb
chore(spanner): comment failing test
harshachinta Dec 18, 2024
606c052
chore(spanner): fix mock server for background request
harshachinta Dec 18, 2024
85e2bb1
chore(spanner): create package protected setter to disable background…
harshachinta Dec 18, 2024
37c0e4f
chore(spanner): comment
harshachinta Dec 18, 2024
289aae7
chore(spanner): revert
harshachinta Dec 18, 2024
b441981
chore(spanner): uncomment
harshachinta Dec 18, 2024
b8de686
chore(spanner): fix tests in databaseClientimplTest
harshachinta Dec 19, 2024
fed3041
chore(spanner): fix tests in SessionPoolLeakTest
harshachinta Dec 19, 2024
082cec1
chore(spanner): skip tests for Retry on differenr grpc channel
harshachinta Dec 19, 2024
82d9fa7
chore(spanner): skip unit tests
harshachinta Dec 19, 2024
a1e72c4
chore(spanner): fix tests
harshachinta Dec 23, 2024
64a93e5
chore(spanner): add mocks for create session with multiplexed session…
harshachinta Dec 23, 2024
2c51c00
chore(spanner): skip tests and fix tests
harshachinta Dec 23, 2024
d7385c3
chore(spanner): unskip tests
harshachinta Dec 23, 2024
138c58f
chore(spanner): skip AsyncRunner tests
harshachinta Dec 23, 2024
7211d2f
chore(spanner): fix failing OpenTelemetrySpanTest
harshachinta Dec 24, 2024
caa7aa1
chore(spanner): fix tests in SpanTest
harshachinta Dec 24, 2024
2606aec
chore(spanner): for mutations only case never do explicit begin befor…
harshachinta Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ jobs:
JOB_TYPE: test
GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS: true
GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_PARTITIONED_OPS: true
GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_FOR_RW: true
units-java8:
# Building using Java 17 and run the tests with Java 8 runtime
name: "units (8)"
Expand Down Expand Up @@ -94,6 +95,7 @@ jobs:
JOB_TYPE: test
GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS: true
GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_PARTITIONED_OPS: true
GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_FOR_RW: true
windows:
runs-on: windows-latest
steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/integration-tests-against-emulator-with-multiplexed-session.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,4 @@ jobs:
JOB_TYPE: test
SPANNER_EMULATOR_HOST: localhost:9010
GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS: true
GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_FOR_RW: true
5 changes: 5 additions & 0 deletions .kokoro/presubmit/integration-multiplexed-sessions-enabled.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,8 @@ env_vars: {
key: "GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_PARTITIONED_OPS"
value: "true"
}

env_vars: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please also change continuous and nightly jobs as well?

key: "GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_FOR_RW"
value: "true"
}
4 changes: 1 addition & 3 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPoolOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,9 +391,7 @@ private static Boolean parseBooleanEnvVariable(String variableName) {
}

private static Boolean getUseMultiplexedSessionForRWFromEnvVariable() {
// Checks the value of env, GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_FOR_RW
// This returns null until RW is supported.
return null;
return parseBooleanEnvVariable("GOOGLE_CLOUD_SPANNER_MULTIPLEXED_SESSIONS_FOR_RW");
}

Duration getMultiplexedSessionMaintenanceDuration() {
Expand Down
Loading