-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(samples): add samples and tests for change streams transaction exclusion #3098
base: main
Are you sure you want to change the base?
docs(samples): add samples and tests for change streams transaction exclusion #3098
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Hi @rahul2393 Could you please take a look at this pr? This is a Java version of GoogleCloudPlatform/golang-samples#4108 for code samples using change streams transaction exclusion. The newest BOM release now contains the needed source code change so this pull request should be ready to merge. Thank you! |
samples/snippets/src/main/java/com/example/spanner/ChangeStreamsTxnExclusionSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/ChangeStreamsTxnExclusionSample.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with some nits on project/instance naming
Convert to draft since this feature is still not fully enabled by default. |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
87cfe16
to
25e2f8b
Compare
Add samples and IT tests on setting
Options.excludeTxnFromChangeStreams()
in various write requests. This is a follow up after #2959