Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): add samples and tests for change streams transaction exclusion #3098

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ShuranZhang
Copy link

Add samples and IT tests on setting Options.excludeTxnFromChangeStreams() in various write requests. This is a follow up after #2959

@ShuranZhang ShuranZhang requested review from a team as code owners May 8, 2024 18:16
Copy link

snippet-bot bot commented May 8, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels May 8, 2024
@ShuranZhang
Copy link
Author

Hi @rahul2393 Could you please take a look at this pr? This is a Java version of GoogleCloudPlatform/golang-samples#4108 for code samples using change streams transaction exclusion. The newest BOM release now contains the needed source code change so this pull request should be ready to merge. Thank you!

Copy link
Contributor

@rahul2393 rahul2393 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some nits on project/instance naming

@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2024
@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label Oct 11, 2024
@ShuranZhang ShuranZhang marked this pull request as draft October 11, 2024 20:11
@ShuranZhang
Copy link
Author

Convert to draft since this feature is still not fully enabled by default.

Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 12, 2024
@ShuranZhang ShuranZhang force-pushed the change-streams-txn-exclusion-sample branch from 87cfe16 to 25e2f8b Compare October 16, 2024 22:29
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants