Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tracing for batchUpdate, executeUpdate, and connections #3097

Merged
merged 19 commits into from
May 15, 2024

Conversation

olavloite
Copy link
Collaborator

@olavloite olavloite commented May 7, 2024

  • Adds OpenTelemetry tracing to the Connection API. This again enables tracing in the JDBC driver and PGAdapter.
  • Adds traces for batchUpdate calls in the Java client library (these calls were not traced).
  • Adds traces for executeUpdate calls in the Java client library (these calls were not traced).
  • Adds an option to include the actual SQL statement that was executed with the trace. This option is disabled by default. The option is named enableExtendedTracing, and might include additional features in the future.
  • Adds the transaction tag and statement tag as attributes to the OpenTelemetry traces. This makes it easier to find traces for specific transactions and statements.

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/java-spanner API. labels May 7, 2024
@olavloite olavloite marked this pull request as ready for review May 8, 2024 09:44
@olavloite olavloite requested a review from a team as a code owner May 8, 2024 09:44
@olavloite olavloite requested a review from a team as a code owner May 8, 2024 09:46
@surbhigarg92
Copy link
Contributor

We should also update the Readme OpenTelemetry about the new Environment Variable and Option

@olavloite
Copy link
Collaborator Author

We should also update the Readme OpenTelemetry about the new Environment Variable and Option

Done

@olavloite olavloite requested a review from surbhigarg92 May 13, 2024 18:01
@olavloite olavloite changed the title chore: add tracing to Connection API feat: add tracing to Connection API + tracing for batchUpdate and executeUpdate May 14, 2024
@olavloite olavloite changed the title feat: add tracing to Connection API + tracing for batchUpdate and executeUpdate feat: add tracing for batchUpdate, executeUpdate, and connections May 14, 2024
@olavloite olavloite added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels May 14, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2024
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 14, 2024
@olavloite olavloite merged commit 45cdcfc into main May 15, 2024
33 of 34 checks passed
@olavloite olavloite deleted the tracing-connection-api branch May 15, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants