refactor: move inner classes to top level #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the gRPC-related inner classes from AbstractResultSet to top-level classes, so they are easier to modify and maintain. This change only contains modifications that are needed to move these inner classes. There are no functional changes.
product-auto-label
bot
added
size: xl
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
rahul2393
approved these changes
Feb 8, 2024
* feat: support lazy decoding of query results Adds an option for lazy decoding of query results. Currently, all values in a query result row are decoded from protobuf values to plain Java objects at the moment that the result set is advanced to the next row. This means that all values are decoded, regardless whether the application actually fetches these or not. Lazy decoding also enables the possibility for (internal) consumers of a result set to access the protobuf value before it is converted to a plain Java object. This for example allows ChecksumResultSet to calculate the checksum based on the protobuf value, instead of a Java object, which can be more efficient. * fix: add null check * perf: calculate checksum using protobuf values (#2848) * perf: calculate checksum using protobuf values * chore: cleanup * test: remove unrelated test * fix: undo change to public API * chore: cleanup|
…-spanner into refactor-grpc-result-set
This was referenced Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the gRPC-related inner classes from AbstractResultSet to top-level classes, so they are easier to modify and maintain.
This change only contains modifications that are needed to move these inner classes. There are no functional changes.
Details
The inner classes that are moved from
AbstractResultSet.javato the top level are:GrpcResultSetGrpcStreamIteratorGrpcStructGrpcValueIteratorResumableStreamIteratorThe above classes were previously all static inner classes defined in the
AbstractResultSetclass, which made that file extremely long and hard to maintain. The changes in this PR all come from moving these classes to individual files. The access modifiers of all these classes were eitherprivateorpackage private. They are now allpackage private, so they can be used within the same package. They are not accessible to outside users, meaning that this refactor does not have any impact on end users.