Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow comments in PG strings #2604

Merged
merged 1 commit into from
Aug 29, 2023
Merged

chore: allow comments in PG strings #2604

merged 1 commit into from
Aug 29, 2023

Conversation

olavloite
Copy link
Collaborator

Allow comments in PostgreSQL query strings for extracting parameter definitions. The comments need to be preserved, as they could contain query hints.

Allow comments in PostgreSQL query strings for extracting parameter
definitions. The comments need to be preserved, as they could contain
query hints.
@olavloite olavloite requested a review from arpan14 August 25, 2023 14:50
@olavloite olavloite requested a review from a team as a code owner August 25, 2023 14:50
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. labels Aug 25, 2023
@olavloite olavloite merged commit bfa777b into main Aug 29, 2023
@olavloite olavloite deleted the allow-pg-comments branch August 29, 2023 13:45
surbhigarg92 pushed a commit to surbhigarg92/java-spanner that referenced this pull request Sep 7, 2023
Allow comments in PostgreSQL query strings for extracting parameter
definitions. The comments need to be preserved, as they could contain
query hints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants