Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding support for databoost #2505

Merged
merged 9 commits into from
Aug 18, 2023
Merged

feat: Adding support for databoost #2505

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e0353a2
feat: Adding support for databoost
gauravpurohit06 Jun 20, 2023
08319fb
Enabling databoost test
gauravpurohit06 Jun 23, 2023
f56933d
Update ITBatchReadTest.java
gauravpurohit06 Jun 23, 2023
6e4085d
Merge branch 'main' into data-boost-enabled
gauravpurohit06 Aug 11, 2023
c645cca
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Aug 11, 2023
a9815d2
docs fix
rajatbhatta Aug 11, 2023
82d1497
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Aug 11, 2023
8af23f4
Merge remote-tracking branch 'upstream/main' into data-boost-enabled
gauravpurohit06 Aug 17, 2023
f74ccbe
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Aug 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/Options.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

package com.google.cloud.spanner;

import com.google.api.core.BetaApi;
import com.google.common.base.Preconditions;
import com.google.spanner.v1.RequestOptions.Priority;
import java.io.Serializable;
Expand Down Expand Up @@ -157,10 +156,8 @@ public static ListOption pageSize(int pageSize) {

/**
* If this is for a partitioned read & query and this field is set to `true`, the request will be
* executed via Spanner independent compute resources. The method is available in Beta mode (and
* is not generally available now).
* executed via Spanner independent compute resources.
*/
@BetaApi
public static DataBoostQueryOption dataBoostEnabled(Boolean dataBoostEnabled) {
rajatbhatta marked this conversation as resolved.
Show resolved Hide resolved
return new DataBoostQueryOption(dataBoostEnabled);
}
Expand Down
4 changes: 0 additions & 4 deletions google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITBatchReadTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,6 @@ public void readUsingIndex() {

@Test
public void dataBoostRead() {
// TODO: Remove the following check during GA
assumeFalse("DataBoost feature is not yet generally available", true);
assumeFalse("Emulator does not support data boost read", isUsingEmulator());

BitSet seenRows = new BitSet(numRows);
Expand Down Expand Up @@ -297,8 +295,6 @@ private PartitionOptions getRandomPartitionOptions() {

@Test
public void dataBoostQuery() {
// TODO: Remove the following check during GA
assumeFalse("DataBoost feature is not yet generally available", true);
assumeFalse("Emulator does not support data boost query", isUsingEmulator());
BitSet seenRows = new BitSet(numRows);
TimestampBound bound = getRandomBound();
Expand Down