-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3 #1960
deps: update dependency com.google.cloud:google-cloud-shared-dependencies to v3 #1960
Conversation
8cc791c
to
bfdace5
Compare
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blakeli0 This is failing 12 ChannelUsageTest
, so multiple required presubmits are failing. Would you be able to take a look?
bfdace5
to
f352560
Compare
@ansh0l The reason that unit tests are failing is that the unit test is using a String literal value(which is supposed to be implementation details) to verify the number of channels created instead of a public key. The value of the key can change at any time, but the key is public so should rarely changes. In this case, grpc changed the value in 1.48.0, and since grpc comes with shared dependencies, the unit test failed. I fixed it in #1965, please take a look. |
f352560
to
2d3be60
Compare
Rebuilding failed Kokoro integration test. |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
This PR contains the following updates:
2.13.0
->3.0.1
Release Notes
googleapis/java-shared-dependencies
v3.0.1
Compare Source
Dependencies
v3.0.0
Compare Source
Bug Fixes
Dependencies
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.