Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: ci to build with JDK 11 (cont.) #1890

Merged
merged 5 commits into from
May 25, 2022
Merged

ci: ci to build with JDK 11 (cont.) #1890

merged 5 commits into from
May 25, 2022

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented May 25, 2022 •
edited
Loading

Testing with GraalVM SDK 22.1.0. (The target branch of this pull request is Mridula's test-compatibility branch).

@suztomo suztomo requested review from a team as code owners May 25, 2022 14:59
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 25, 2022
@generated-files-bot
Copy link

generated-files-bot bot commented May 25, 2022 •
edited
Loading

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml
  • .kokoro/common.sh
  • .kokoro/dependencies.sh

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label May 25, 2022
@suztomo suztomo force-pushed the java8_with_graal_sdk_22.1 branch from 653f3cb to 43f023f Compare May 25, 2022 15:01
@suztomo
Copy link
Member Author

suztomo commented May 25, 2022 •
edited
Loading

Manually trigerred http://sponge2/35e9a855-aa8f-4092-ae5f-91e081b6dacc with this pull request 1890. The flag "-Dmaven.main.skip=true" successfully avoided re-compiling the module.

...
Java version: 1.8.0_332, vendor: Oracle Corporation, runtime: /usr/local/openjdk-8/jre
...
[INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ google-cloud-spanner ---
[INFO] Not compiling main sources

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 25, 2022
@suztomo suztomo force-pushed the java8_with_graal_sdk_22.1 branch from 9d5220e to 155b253 Compare May 25, 2022 15:38
@suztomo suztomo changed the title ci: java8 test to build with JDK 11 (cont.) ci: ci to build with JDK 11 (cont.) May 25, 2022
@suztomo
Copy link
Member Author

suztomo commented May 25, 2022

@mpeddada1 All checks (the ones failed in #1858 (comment)) passed. Merge this when you're ready. The marge target branch is yours.

@mpeddada1 mpeddada1 merged commit b6119aa into googleapis:test-compatibility May 25, 2022
@mpeddada1 mpeddada1 mentioned this pull request May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpeddada1 mpeddada1 mpeddada1 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suztomo @mpeddada1