Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add samples for PostgreSQL #1700

Merged
merged 9 commits into from
Apr 21, 2022
Merged

docs: add samples for PostgreSQL #1700

merged 9 commits into from
Apr 21, 2022

Conversation

olavloite
Copy link
Collaborator

@olavloite olavloite commented Feb 18, 2022 •
edited
Loading

Adds samples specifically for PG dialect databases.

cc @jin-jj

@olavloite olavloite added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 18, 2022
@olavloite olavloite requested review from a team as code owners February 18, 2022 11:46
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Feb 18, 2022
@snippet-bot
Copy link

snippet-bot bot commented Feb 18, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 18, 2022
@olavloite olavloite requested a review from ansh0l February 18, 2022 11:46
@olavloite olavloite removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 10, 2022
jin-jj
jin-jj reviewed Mar 10, 2022
View reviewed changes
samples/snippets/src/main/java/com/example/spanner/PgCaseSensitivitySample.java Outdated Show resolved Hide resolved
samples/snippets/src/main/java/com/example/spanner/PgInterleavedTableSample.java
+ " AlbumId bigint NOT NULL,"
+ " Title varchar(1024) NOT NULL,"
+ " PRIMARY KEY (SingerId, AlbumId)"
+ ") INTERLEAVE IN PARENT Singers ON DELETE CASCADE"),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have sample for drop? One of the benefit is that we only support cascade drop for interleaved table.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly do you mean? I don't think we support cascade drop, only cascade delete. Or is that what you meant?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, yep, delete.

ansh0l
ansh0l approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jin-jj : Can you have a look at the PR if it looks ok to you? Now that we have the PR for existing samples available, I think this can be merged together with that one. So marking it as approved.

@ansh0l ansh0l mentioned this pull request Mar 24, 2022
Closed
@jin-jj
Copy link

jin-jj commented Mar 24, 2022

LGTM.

@jin-jj : Can you have a look at the PR if it looks ok to you? Now that we have the PR for existing samples available, I think this can be merged together with that one. So marking it as approved.

LGTM. I have a comment about the INTERLEAVE IN on delete cascade, but let's worry about it later.

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Apr 21, 2022
@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label Apr 21, 2022
@olavloite olavloite merged commit a024483 into main Apr 21, 2022
@olavloite olavloite deleted the pg-samples branch April 21, 2022 13:57
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 21, 2022
@release-please release-please bot mentioned this pull request Apr 21, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 21, 2022
@release-please
chore(main): release 6.23.3 (#1836)
1cf4cab 
🤖 I have created a release *beep* *boop*
---


### [6.23.3](v6.23.2...v6.23.3) (2022-04-21)


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.10.0 ([#1830](#1830)) ([3c55eb3](3c55eb3))


### Documentation

* add samples for PostgreSQL ([#1700](#1700)) ([a024483](a024483))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jin-jj jin-jj jin-jj left review comments

@ansh0l ansh0l ansh0l approved these changes

Assignees

@stephaniewang526 stephaniewang526

Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olavloite @jin-jj @ansh0l @stephaniewang526