Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: adds samples for CMEK #1044

Closed
wants to merge 1 commit into from
Closed

Conversation

olavloite
Copy link
Collaborator

See #1043

Temporarily reverts the addition of these samples, as encryption is not yet available in the Spanner client that is included in the BOM. Encryption requires Spanner client library version 6.x. The current BOM version is 5.1.0.

Reverts #989

@olavloite olavloite requested a review from a team as a code owner April 8, 2021 06:14
@olavloite olavloite requested a review from a team April 8, 2021 06:14
@olavloite olavloite requested a review from a team as a code owner April 8, 2021 06:14
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 8, 2021
@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Apr 8, 2021
@thiagotnunes
Copy link
Contributor

Hum that is a good catch, but we can not revert these, otherwise the documentation will break.

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #1044 (473bc12) into master (3b44e55) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1044      +/-   ##
============================================
+ Coverage     85.22%   85.26%   +0.03%     
- Complexity     2657     2661       +4     
============================================
  Files           155      155              
  Lines         14453    14453              
  Branches       1362     1362              
============================================
+ Hits          12318    12323       +5     
+ Misses         1566     1562       -4     
+ Partials        569      568       -1     
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/spanner/SessionPoolOptions.java 69.53% <0.00%> (ø) 18.00% <0.00%> (+1.00%)
...cloud/spanner/connection/ReadWriteTransaction.java 82.38% <0.00%> (+0.27%) 60.00% <0.00%> (+1.00%)
...ain/java/com/google/cloud/spanner/SessionPool.java 89.12% <0.00%> (+0.38%) 73.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b44e55...473bc12. Read the comment docs.

@thiagotnunes
Copy link
Contributor

We updated the bom version now: dcfe398. This PR should be unnecessary.

@thiagotnunes thiagotnunes added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 13, 2021
@olavloite olavloite closed this Apr 13, 2021
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants