Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner.connection.it.ITAsyncTransactionRetryTest: testRetryHighAbortRate failed #3541

Closed
flaky-bot bot opened this issue Dec 10, 2024 · 1 comment · Fixed by #3551
Closed

spanner.connection.it.ITAsyncTransactionRetryTest: testRetryHighAbortRate failed #3541

flaky-bot bot opened this issue Dec 10, 2024 · 1 comment · Fixed by #3551
Assignees
@rahul2393
Labels
api: spanner Issues related to the googleapis/java-spanner API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Dec 10, 2024

Note: #977 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: 331942f
buildURL: Build Status, Sponge
status: failed
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 10, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Dec 10, 2024
@flaky-bot Flaky Bot
Copy link
Author

flaky-bot bot commented Dec 10, 2024

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

When run at the same commit (331942f), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Dec 10, 2024
olavloite added a commit that referenced this issue Dec 13, 2024
@olavloite
chore: reset default to platform thread
53f8117 
Reset the default to using a platform thread for connections. This was the
default before adding an option for setting the executor type, and the new
default is causing problems with the async Connection API.

Fixes #3541
@olavloite olavloite mentioned this issue Dec 13, 2024
Merged
surbhigarg92 pushed a commit to surbhigarg92/java-spanner that referenced this issue Dec 26, 2024
@olavloite @surbhigarg92
chore: reset default to platform thread (googleapis#3551)
3662b56 
Reset the default to using a platform thread for connections. This was the
default before adding an option for setting the executor type, and the new
default is causing problems with the async Connection API.

Fixes googleapis#3541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul2393 rahul2393

Labels
api: spanner Issues related to the googleapis/java-spanner API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: reset default to platform thread googleapis/java-spanner
1 participant
@rahul2393