-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tracing for batchUpdate, executeUpdate, and connections #3097
Conversation
Create one combined option for extended tracing, and disable this option by default for both the Connection API and the standard client.
google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/TraceWrapper.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/DdlBatch.java
Show resolved
Hide resolved
...loud-spanner/src/test/java/com/google/cloud/spanner/connection/OpenTelemetryTracingTest.java
Show resolved
Hide resolved
We should also update the Readme OpenTelemetry about the new Environment Variable and Option |
Done |
…s/java-spanner into tracing-connection-api
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
batchUpdate
calls in the Java client library (these calls were not traced).executeUpdate
calls in the Java client library (these calls were not traced).enableExtendedTracing
, and might include additional features in the future.