Set number of threads for async executor provider as a system property #2631
Assignees
Labels
api: spanner
Issues related to the googleapis/java-spanner API.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Comments
olavloite
added
the
type: feature request
product-auto-label
bot
added
the
api: spanner
olavloite
added a commit
that referenced
this issue
Sep 18, 2023
Add support for setting the core pool size for the thread pool that is used for the Async API using a system property. This allows users to change this property without having to change code, and to set the property if they are using a framework that builds on top of the client library, but that does not have a configuration option for setting a custom executor provider. Fixes #2631
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Oct 4, 2023
…#2632) Add support for setting the core pool size for the thread pool that is used for the Async API using a system property. This allows users to change this property without having to change code, and to set the property if they are using a framework that builds on top of the client library, but that does not have a configuration option for setting a custom executor provider. Fixes #2631
surbhigarg92
pushed a commit
to surbhigarg92/java-spanner
that referenced
this issue
Oct 5, 2023
…googleapis#2632) Add support for setting the core pool size for the thread pool that is used for the Async API using a system property. This allows users to change this property without having to change code, and to set the property if they are using a framework that builds on top of the client library, but that does not have a configuration option for setting a custom executor provider. Fixes googleapis#2631
gcf-merge-on-green bot
pushed a commit
that referenced
this issue
Oct 10, 2023
🤖 I have created a release *beep* *boop* --- ## [6.50.0](https://togithub.com/googleapis/java-spanner/compare/v6.49.0...v6.50.0) (2023-10-09) ### Features * Support setting core pool size for async API in system property ([#2632](https://togithub.com/googleapis/java-spanner/issues/2632)) ([e51c55d](https://togithub.com/googleapis/java-spanner/commit/e51c55d332bacb9d174a24b0d842b2cba4762db8)), closes [#2631](https://togithub.com/googleapis/java-spanner/issues/2631) ### Dependencies * Update dependency com.google.cloud:google-cloud-trace to v2.24.0 ([#2577](https://togithub.com/googleapis/java-spanner/issues/2577)) ([311c2ad](https://togithub.com/googleapis/java-spanner/commit/311c2ad97311490893f3abf4da5fe4d511c445dd)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
ExecutorProviderthat is used for the Async API in the client library can be set using theSpannerOptions$Builder#setAsyncExecutorProvidermethod. This makes it possible for direct users of the Async API to determine the type of executor and the number of threads to use. This configuration is however not accessible to anyone using an abstraction on top of the client library, such as the Spanner R2DBC driver, unless that abstraction has also added support for this configuration property to their own API.When no
ExecutorProviderhas been set, the Java client library will use a default 8-threadExecutor. The '8 threads' is currently hard-coded. We should change this hard-coded value into one that can be set with a system property, so users of both the client library and any driver that builds on top of it can set a different default.The text was updated successfully, but these errors were encountered: