-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add native image configurations for Spanner classes #1858
Conversation
…er into test-compatibility
First run of CI succeeded. Pulling in changes from main to verify again |
Native Image tests still green after pulling in recent changes in main |
Checks still passing after merging recent changes from main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@mpeddada1 : Please close the other PRs around native image testing if this is the final one to be merged.
Looks like we're experiencing some failures due to Java 8 compilation issues. Will wait for #1870 to be merged. |
Closing since native image changes have been released with #1878 |
Sorry @ansh0l, I'll have to reopen this PR. We were blocked on some Java compatibility issues which was introduces with the most recent version of GraalVM so this PR is yet to be merged. |
…er into test-compatibility
samples / compile (8)It failed:
Checking... The root cause is that the "samples / compile (8)" first compiles the root project (which now requires JDK 11).
Kokoro - Test: IntegrationThe compile "JDK11 and running test JDK8" somehow didn't work. It tries to recompile the google-cloud-spanner module saying "Change detected":
integration-tests-against-emulator / unitsThe maven command in .github/workflows/integration-tests-against-emulator.yaml needs to be updated. |
Warning: This pull request is touching the following templated files:
|
All checks are passing after #1890. |
🤖 I have created a release *beep* *boop* --- ### [6.25.3](v6.25.2...v6.25.3) (2022-05-25) ### Bug Fixes * add native image configurations for Spanner classes ([#1858](#1858)) ([92d0292](92d0292)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
No description provided.