Skip to content

Commit

Permalink
fix: include an explicit version for javax-annotations-api (#261)
Browse files Browse the repository at this point in the history
The Maven flatten plugin transforms the pom of the project from a set of imports
and transitive dependencies into a pom that contains all dependencies and versions
explicitly. This process did however miss the javax-annotations-api dependency that
is only included for JDK9 and higher.

Fixes GoogleCloudPlatform/java-docs-samples#3139
  • Loading branch information
olavloite authored Jun 11, 2020
1 parent 22ed458 commit e256d22
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion google-cloud-spanner-bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-spanner</artifactId>
<type>test-jar</type>
<version>1.55.1</version><!-- {x-version-update:google-cloud-spanner:current} -->
<version>1.55.2-SNAPSHOT</version><!-- {x-version-update:google-cloud-spanner:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
Expand Down
1 change: 1 addition & 0 deletions google-cloud-spanner/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@
<dependency>
<groupId>javax.annotation</groupId>
<artifactId>javax.annotation-api</artifactId>
<version>1.3.2</version>
</dependency>
</dependencies>
</profile>
Expand Down
1 change: 1 addition & 0 deletions grpc-google-cloud-spanner-v1/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
<dependency>
<groupId>javax.annotation</groupId>
<artifactId>javax.annotation-api</artifactId>
<version>1.3.2</version>
</dependency>
</dependencies>
</profile>
Expand Down

0 comments on commit e256d22

Please sign in to comment.