Skip to content

Commit

Permalink
fix: ignore UnsupportedOperationException for virtual threads (#2866)
Browse files Browse the repository at this point in the history
The virtual threads util that tries to create a virtual thread factory on JVMs that support this would fail on Java 20, because:
1. Java 20 supports virtual threads as an experimental feature. This means that the code is present.
2. The feature is by default disabled, and throws an UnsupportedOperationException.

This fix takes the above into account and returns null if a user tries to create a virtual threads factory on Java 20 with experimental features disabled.
  • Loading branch information
olavloite authored Feb 7, 2024
1 parent 79c30d2 commit aa9ad7f
Showing 1 changed file with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ public static ThreadFactory tryCreateVirtualThreadFactory(String baseNameFormat)
} catch (ClassNotFoundException | NoSuchMethodException ignore) {
return null;
} catch (InvocationTargetException | IllegalAccessException e) {
// Java 20 supports virtual threads as an experimental feature. It will throw an
// UnsupportedOperationException if experimental features have not been enabled.
if (e.getCause() instanceof UnsupportedOperationException) {
return null;
}
throw new RuntimeException(e);
}
}
Expand All @@ -91,6 +96,11 @@ public static ExecutorService tryCreateVirtualThreadPerTaskExecutor(String baseN
} catch (NoSuchMethodException ignore) {
return null;
} catch (InvocationTargetException | IllegalAccessException e) {
// Java 20 supports virtual threads as an experimental feature. It will throw an
// UnsupportedOperationException if experimental features have not been enabled.
if (e.getCause() instanceof UnsupportedOperationException) {
return null;
}
throw new RuntimeException(e);
}
}
Expand Down

0 comments on commit aa9ad7f

Please sign in to comment.