-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tests for DML with Returning clause #936
Merged
gcf-merge-on-green
merged 11 commits into
googleapis:main
from
rajatbhatta:dml-returning-parsing-changes
Nov 21, 2022
Merged
feat: add tests for DML with Returning clause #936
gcf-merge-on-green
merged 11 commits into
googleapis:main
from
rajatbhatta:dml-returning-parsing-changes
Nov 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Pull request size is medium.
api: spanner
Issues related to the googleapis/java-spanner-jdbc API.
labels
Aug 22, 2022
Note: Integration tests are not expected to pass until DML with Returning clause support is launched. |
olavloite
approved these changes
Aug 23, 2022
src/test/java/com/google/cloud/spanner/jdbc/JdbcStatementTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/cloud/spanner/jdbc/it/ITJdbcPreparedStatementTest.java
Outdated
Show resolved
Hide resolved
rajatbhatta
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Aug 23, 2022
src/test/java/com/google/cloud/spanner/jdbc/JdbcStatementTest.java
Outdated
Show resolved
Hide resolved
thiagotnunes
approved these changes
Aug 30, 2022
rajatbhatta
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Nov 9, 2022
rajatbhatta
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
automerge
Merge the pull request once unit tests and other checks pass.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Nov 21, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Nov 21, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Nov 21, 2022
rajatbhatta
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Nov 21, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Nov 21, 2022
rajatbhatta
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Nov 21, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Nov 21, 2022
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/java-spanner-jdbc API.
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for running DML with Returning clause using the JDBC driver, and incorporates the following:
execute
,executeUpdate
,executeQuery
,executeBatchUpdate
.