Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update dependency com.google.cloud:google-cloud-spanner-bom to v6.27.0 #898

Merged
merged 1 commit into from
Jul 20, 2022
Merged

deps: update dependency com.google.cloud:google-cloud-spanner-bom to v6.27.0 #898

merged 1 commit into from
Jul 20, 2022

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Jun 22, 2022 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.cloud:google-cloud-spanner-bom 6.25.5 -> 6.27.0 age adoption passing confidence

Release Notes

googleapis/java-spanner

v6.27.0

Compare Source

Features
  • Adding new fields for Instance Create Time and Update Time (#​1913) (2c71e02)
Dependencies
  • update dependency com.google.cloud:google-cloud-monitoring to v3.3.1 (#​1933) (e3d646b)
  • update dependency org.graalvm.buildtools:junit-platform-native to v0.9.13 (#​1944) (765d11b)
  • update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.13 (#​1945) (0da75b8)
  • update dependency org.graalvm.sdk:graal-sdk to v22.2.0 (#​1953) (c7f1040)

v6.26.0

Compare Source

Features
Bug Fixes
Dependencies
  • update dependency com.google.cloud:google-cloud-trace to v2.3.0 (#​1934) (2813eb2)

v6.25.7

Compare Source

Dependencies
  • update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 (#​1924) (dde5ee8)
  • update dependency org.graalvm.buildtools:junit-platform-native to v0.9.12 (#​1906) (1800cd9)

v6.25.6

Compare Source

Bug Fixes
Documentation
Dependencies
  • update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.11 (#​1907) (01f8a07)
  • update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 (#​1918) (be8b50b)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested review from a team as code owners June 22, 2022 14:32
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 22, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 22, 2022
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels Jun 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2022
@meltsufin meltsufin added the automerge Merge the pull request once unit tests and other checks pass. label Jun 22, 2022
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 23, 2022
@rajatbhatta
Copy link
Contributor

Hi @olavloite, can you please look into the failing test here? Seems to be related to some recent change in PostgreSQLStatementParser. Thanks!

Error: JdbcParameterStoreTest.testPostgresDialectConvertPositionalParametersToNamedParameters:899 » Spanner INVALID_ARGUMENT: SQL statement contains an unclosed literal: ?'?it\'?s'?

@renovate-bot renovate-bot changed the title deps: update dependency com.google.cloud:google-cloud-spanner-bom to v6.25.6 deps: update dependency com.google.cloud:google-cloud-spanner-bom to v6.25.7 Jun 30, 2022
@renovate-bot renovate-bot force-pushed the renovate/com.google.cloud-google-cloud-spanner-bom-6.x branch from 3325661 to 5ffb8d7 Compare June 30, 2022 05:48
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 30, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2022
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2022
@renovate-bot renovate-bot force-pushed the renovate/com.google.cloud-google-cloud-spanner-bom-6.x branch from 5ffb8d7 to 76016f4 Compare July 13, 2022 15:49
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 13, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 13, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2022
@alicejli
Copy link
Contributor

@olavloite gentle bump - are you able to take a look? Looks like there was a similar issue you handled in the spanner repo: googleapis/java-spanner#1730

olavloite added a commit that referenced this pull request Jul 14, 2022
@olavloite
test: modify tests to use correct quote escaping
feef527 
Some tests used invalid escaping of quotes in PostgreSQL queries. They
assumed that a quote in a quoted string could be escaped by prefixing
it with a backslash. This is however not allowed in PostgreSQL, and
instead the quote must be escaped by including the same quote twice in
the string.
The Spanner Java client library contained a bug that allowed the
backslash-escaped quotes to be accepted. This bug has been fixed in
6.25.7 and these tests therefore need to be modified to be able to
update to that version.

Fixes the build error in #898
@olavloite olavloite mentioned this pull request Jul 14, 2022
Merged
@olavloite
Copy link
Collaborator

@alicejli @rajatbhatta Sorry, I missed the initial request. I've applied a fix in #909. Once that is merged, a rebase of this PR should make the build failure go away.

@mpeddada1 mpeddada1 mentioned this pull request Jul 14, 2022
Closed
@renovate-bot renovate-bot changed the title deps: update dependency com.google.cloud:google-cloud-spanner-bom to v6.25.7 deps: update dependency com.google.cloud:google-cloud-spanner-bom to v6.26.0 Jul 18, 2022
@renovate-bot renovate-bot force-pushed the renovate/com.google.cloud-google-cloud-spanner-bom-6.x branch from 76016f4 to 41b16ca Compare July 18, 2022 09:57
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2022
@renovate-bot renovate-bot force-pushed the renovate/com.google.cloud-google-cloud-spanner-bom-6.x branch from 41b16ca to 9bb964b Compare July 18, 2022 15:36
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2022
rajatbhatta pushed a commit that referenced this pull request Jul 18, 2022
@olavloite
test: modify tests to use correct quote escaping (#909)
57a0c7c 
Some tests used invalid escaping of quotes in PostgreSQL queries. They
assumed that a quote in a quoted string could be escaped by prefixing
it with a backslash. This is however not allowed in PostgreSQL, and
instead the quote must be escaped by including the same quote twice in
the string.
The Spanner Java client library contained a bug that allowed the
backslash-escaped quotes to be accepted. This bug has been fixed in
6.25.7 and these tests therefore need to be modified to be able to
update to that version.

Fixes the build error in #898
@rajatbhatta rajatbhatta added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jul 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 19, 2022
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 19, 2022
@renovate-bot renovate-bot changed the title deps: update dependency com.google.cloud:google-cloud-spanner-bom to v6.26.0 deps: update dependency com.google.cloud:google-cloud-spanner-bom to v6.27.0 Jul 20, 2022
@renovate-bot renovate-bot force-pushed the renovate/com.google.cloud-google-cloud-spanner-bom-6.x branch from 9bb964b to 2d016fa Compare July 20, 2022 00:08
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2022
@lqiu96 lqiu96 added the automerge Merge the pull request once unit tests and other checks pass. label Jul 20, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit c536dd6 into googleapis:main Jul 20, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 20, 2022
@renovate-bot renovate-bot deleted the renovate/com.google.cloud-google-cloud-spanner-bom-6.x branch July 20, 2022 18:24
@release-please release-please bot mentioned this pull request Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@renovate-bot @rajatbhatta @alicejli @olavloite @meltsufin @lqiu96 @yoshi-kokoro