Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add duplicate class exclusion for gapic-generator-java artifact #5962

Merged
merged 3 commits into from
May 1, 2023

Conversation

emmileaf
Copy link
Contributor

@emmileaf emmileaf commented May 1, 2023

This PR adds an exclusion for the gapic-generator-java artifact in assertUniqueClasses to resolve issue from #5961 (comment).

Context: BOMContentTest currently fails since inclusion of this artifact in gapic-generator-java-bom as of v2.18.0 (googleapis/gapic-generator-java#1645). gapic-generator-java is not intended for use by client libraries, and was added for downstream usage by the spring-cloud-gcp code generator (GoogleCloudPlatform/spring-cloud-gcp#1686).

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 1, 2023
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmation might be a bit difficult. Try-and-error via multiple pull requests is ok.

tests/src/test/java/com/google/cloud/BomContentTest.java Outdated Show resolved Hide resolved
@emmileaf
Copy link
Contributor Author

emmileaf commented May 1, 2023

Confirmation might be a bit difficult. Try-and-error via multiple pull requests is ok.

Sounds good. Thanks @suztomo!

@emmileaf emmileaf marked this pull request as ready for review May 1, 2023 20:08
@emmileaf emmileaf requested a review from a team as a code owner May 1, 2023 20:08
@emmileaf emmileaf merged commit 684f754 into main May 1, 2023
@emmileaf emmileaf deleted the duplicate-classes-from-generator branch May 1, 2023 20:12
@emmileaf emmileaf added the release-please:force-run To run release-please label May 1, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label May 1, 2023
@emmileaf emmileaf mentioned this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants