Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove auth dependencies version and rely on sdk-platform-java-config #2679

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Oct 3, 2024

These dependencies were added in #2388 with hardcoded versions.
We prefer getting these versions from sdk-platform-java-config (includes both auth and gax versions).

auth is included in dependencyManagement here in gapic-generator-java-bom, which is part of first-party-dependencies, and eventually included via sdk-platform-java-config.

@zhumin8 zhumin8 requested review from a team as code owners October 3, 2024 02:57
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Oct 3, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Oct 3, 2024
@zhumin8 zhumin8 changed the title chore: remove auth dependencies and get transitively from gax. chore: remove auth dependencies version and rely on sdk-platform-java-config Oct 3, 2024
@zhumin8 zhumin8 merged commit ed18784 into main Oct 3, 2024
20 of 21 checks passed
@zhumin8 zhumin8 deleted the rm-auth-deps branch October 3, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants