feat: Add header back to the client #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: m
GaoleMeng
approved these changes
Feb 28, 2023
| @@ -297,6 +319,25 @@ public void run(Throwable finalStatus) { | |||
|
|
|||
| /** Schedules the writing of rows at given offset. */ | |||
| ApiFuture<AppendRowsResponse> append(StreamWriter streamWriter, ProtoRows rows, long offset) { | |||
| if (this.location != null && this.location != streamWriter.getLocation()) { | |||
| log.info("111111"); | |||
yirutang
added
kokoro:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
🤖 I have created a release *beep* *boop* --- ## [2.33.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.32.1...v2.33.0) (2023-03-01) ### Features * Add header back to the client ([#2016](https://togithub.com/googleapis/java-bigquerystorage/issues/2016)) ([de00447](https://togithub.com/googleapis/java-bigquerystorage/commit/de00447958e5939d7be9d0f7da02323aabbfed8c)) ### Bug Fixes * Add client shutdown if request waiting in request queue for too long. ([#2017](https://togithub.com/googleapis/java-bigquerystorage/issues/2017)) ([91da88b](https://togithub.com/googleapis/java-bigquerystorage/commit/91da88b0ed914bf55111dd9cef2a3fc4b27c3443)) * Allow StreamWriter settings to override passed in BQ client setting ([#2001](https://togithub.com/googleapis/java-bigquerystorage/issues/2001)) ([66db8fe](https://togithub.com/googleapis/java-bigquerystorage/commit/66db8fed26474076fb5aaca5044d39e11f6ef28d)) * Catch uncaught exception from append loop and add expoential retry to reconnection ([#2015](https://togithub.com/googleapis/java-bigquerystorage/issues/2015)) ([35db0fb](https://togithub.com/googleapis/java-bigquerystorage/commit/35db0fb38a929a8f3e4db30ee173ce5a4af43d64)) * Remove write_location header pending discussion ([#2021](https://togithub.com/googleapis/java-bigquerystorage/issues/2021)) ([0941d43](https://togithub.com/googleapis/java-bigquerystorage/commit/0941d4363daf782e0be81c11fdf6a2fe0ff4d7ac)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write API is going to use GFE dynamic routing instead of global router. Once that is migrated, header is needed for routing decisions.