-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add precision overwritten to 9 digit if the passed in JSON type is FLOAT or DOUBLE #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prerequisite for multiplexing client
new stream name as a switch of destinationt
also fixed a tiny bug inside fake bigquery write impl for getting thre response from offset
possible the proto schema does not contain this field
GaoleMeng
changed the title
[fix]: add precision overwritten to 9 digit if the passed in JSON type is FLOAT or DOUBLE
fix: add precision overwritten to 9 digit if the passed in JSON type is FLOAT or DOUBLE
Jan 17, 2023
GaoleMeng
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jan 17, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jan 17, 2023
GaoleMeng
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
kokoro:run
Add this label to force Kokoro to re-run the tests.
labels
Jan 17, 2023
yoshi-kokoro
removed
kokoro:run
Add this label to force Kokoro to re-run the tests.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Jan 17, 2023
GaoleMeng
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jan 17, 2023
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jan 17, 2023
GaoleMeng
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
kokoro:run
Add this label to force Kokoro to re-run the tests.
labels
Jan 17, 2023
yoshi-kokoro
removed
kokoro:run
Add this label to force Kokoro to re-run the tests.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Jan 17, 2023
GaoleMeng
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jan 17, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jan 17, 2023
GaoleMeng
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
kokoro:run
Add this label to force Kokoro to re-run the tests.
labels
Jan 17, 2023
yoshi-kokoro
removed
kokoro:run
Add this label to force Kokoro to re-run the tests.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Jan 17, 2023
GaoleMeng
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jan 17, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jan 17, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 18, 2023
🤖 I have created a release *beep* *boop* --- ## [2.28.2](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.28.1...v2.28.2) (2023-01-18) ### Bug Fixes * Add a timeout on retry for retryable errors ([#1930](https://togithub.com/googleapis/java-bigquerystorage/issues/1930)) ([2d648cf](https://togithub.com/googleapis/java-bigquerystorage/commit/2d648cf9706a6e7bc155e8769ba7dda2a6bc3061)) * Add precision overwritten to 9 digit if the passed in JSON type is FLOAT or DOUBLE ([#1932](https://togithub.com/googleapis/java-bigquerystorage/issues/1932)) ([417bc6c](https://togithub.com/googleapis/java-bigquerystorage/commit/417bc6c76f7b9fa602721c3c183c487c5aab2e09)) ### Dependencies * Update dependency com.google.cloud:google-cloud-bigquery to v2.20.2 ([#1929](https://togithub.com/googleapis/java-bigquerystorage/issues/1929)) ([a95ae9d](https://togithub.com/googleapis/java-bigquerystorage/commit/a95ae9d708bd3e2d8f55297a6004a0d937c8d83f)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquerystorage
Issues related to the googleapis/java-bigquerystorage API.
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for JSON, decimal value's precision is machine dependent, a 0.1 passed in could be resulted to 0.100000005
which will fail the scale check done inside BigDecimalByteStringEncoder.encodeToNumericByteString
we should round the number to 9 digit precision to prevent customer's need to convert to string value for decimal value
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.