Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add test to check newBuilder for JsonStreamWriter #1796

Merged
merged 6 commits into from
Sep 23, 2022
Merged

chore: add test to check newBuilder for JsonStreamWriter #1796

merged 6 commits into from
Sep 23, 2022

Conversation

Neenu1995
Copy link
Contributor

@Neenu1995 Neenu1995 commented Sep 23, 2022 •
edited
Loading

End to end tests added to test the newBuilder() method added to JsonStreamWriter which enables users to create JsonStreamWriter without explicitly providing a Table Schema.

This PR has the following tests:

  • Test to check that the JsonStreamWriter generated with the new methods works as expected.
  • Test to check that the JsonStreamWriter generated with the newBuilder method is working exactly same as the JsonStreamWriter generated with older NewBuilder method by explicitly providingTableSchema.

@Neenu1995 Neenu1995 requested review from a team and aribray September 23, 2022 01:34
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Sep 23, 2022
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2022
@Neenu1995 Neenu1995 requested review from yirutang and removed request for aribray September 23, 2022 01:40
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2022
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2022
@Neenu1995 Neenu1995 requested a review from yirutang September 23, 2022 19:00
@Neenu1995 Neenu1995 merged commit f6083be into main Sep 23, 2022
@Neenu1995 Neenu1995 deleted the test-write-stream-view branch September 23, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yirutang yirutang yirutang approved these changes

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Neenu1995 @yirutang @yoshi-kokoro