Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: fixing the test scope dependency to runtime #1742

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Aug 9, 2022

Fixing the test-scope dependency to runtime. The flatten maven plugin does not interpret test scope dependency correctly.

The test scope was added recently: https://github.com/googleapis/java-bigquerystorage/pull/1720/files#diff-273690ed1fb8c3821089309482b75cb6b6de18d07238cb82c74cb1855e215904 . This would cause problem like googleapis/java-pubsub#1239

@suztomo suztomo requested a review from a team as a code owner August 9, 2022 15:27
@suztomo suztomo requested review from a team and shollyman August 9, 2022 15:27
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 9, 2022
@suztomo suztomo requested a review from blakeli0 August 9, 2022 15:27
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Aug 9, 2022
@suztomo suztomo added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Aug 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 9, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 878020b into main Aug 9, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the suztomo-patch-1 branch August 9, 2022 15:48
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants